Received: from eggs.gnu.org ([2001:4830:134:3::10]:47164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgE4c-0002bQ-1A for qemu-devel@nongnu.org; Mon, 20 Oct 2014 10:36:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgE4P-000600-4i for qemu-devel@nongnu.org; Mon, 20 Oct 2014 10:36:37 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:42180 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgE4O-0005zY-Qf for qemu-devel@nongnu.org; Mon, 20 Oct 2014 10:36:25 -0400 From: Peter Lieven Date: Mon, 20 Oct 2014 16:35:20 +0200 Message-Id: <1413815720-29976-5-git-send-email-pl@kamp.de> In-Reply-To: <1413815720-29976-1-git-send-email-pl@kamp.de> References: <1413815720-29976-1-git-send-email-pl@kamp.de> Subject: [Qemu-devel] [PATCH 4/4] hw/virtio-blk: add a constant for max number of merged requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net, jcody@redhat.com, Peter Lieven , mreitz@redhat.com, stefanha@redhat.com As it was not obvious (at least for me) where the 32 comes from add a constant for it. Signed-off-by: Peter Lieven --- hw/block/virtio-blk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 6051027..23bc948 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -308,6 +308,8 @@ static bool virtio_blk_sect_range_ok(VirtIOBlock *dev, return true; } +#define MAX_MERGED_REQS 32 + static void virtio_blk_handle_write(VirtIOBlockReq *req, MultiReqBuffer *mrb) { BlockRequest *blkreq; @@ -326,7 +328,7 @@ static void virtio_blk_handle_write(VirtIOBlockReq *req, MultiReqBuffer *mrb) block_acct_start(blk_get_stats(req->dev->blk), &req->acct, req->qiov.size, BLOCK_ACCT_WRITE); - if (mrb->num_writes == 32) { + if (mrb->num_writes == MAX_MERGED_REQS) { virtio_submit_multiwrite(req->dev->blk, mrb); } -- 1.7.9.5