From: Bob Peterson Date: Tue, 17 Nov 2020 14:40:52 -0500 (EST) Subject: [Cluster-devel] [GFS2 PATCH] gfs2: Fix regression in freeze_go_sync In-Reply-To: <796995883.26198021.1605642034293.JavaMail.zimbra@redhat.com> Message-ID: <1414973099.26198026.1605642052913.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, Patch 541656d3a51 ("gfs2: freeze should work on read-only mounts") changed the check for glock state in function freeze_go_sync() from "gl->gl_state == LM_ST_SHARED" to "gl->gl_req == LM_ST_EXCLUSIVE". That's wrong and it regressed gfs2's freeze/thaw mechanism. We need to check gl_state == LM_ST_SHARED and not gl_req == LM_ST_EXCLUSIVE because when any node does a freeze, all the nodes should have the freeze glock in SH mode and they all call do_xmote: One node for EX and the others for UN. They ALL must freeze locally, and they ALL must queue freeze work. The freeze_work calls freeze_func, which reacquires the freeze glock in SH, effectively waiting for the thaw on the node who holds the freeze glock in EX. Once thawed, the freeze_func acquires the freeze glock in SH and everybody goes back to thawed. Fixes: 541656d3a51 ("gfs2: freeze should work on read-only mounts") Signed-off-by: Bob Peterson --- fs/gfs2/glops.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index 6c1432d78dce..67f2921ae8d4 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2/glops.c @@ -571,7 +571,18 @@ static int freeze_go_sync(struct gfs2_glock *gl) int error = 0; struct gfs2_sbd *sdp = gl->gl_name.ln_sbd; - if (gl->gl_req == LM_ST_EXCLUSIVE && !gfs2_withdrawn(sdp)) { + /* + * We need to check gl_state == LM_ST_SHARED here and not gl_req == + * LM_ST_EXCLUSIVE. That's because when any node does a freeze, + * all the nodes should have the freeze glock in SH mode and they all + * call do_xmote: One for EX and the others for UN. They ALL must + * freeze locally, and they ALL must queue freeze work. The freeze_work + * calls freeze_func, which tries to reacquire the freeze glock in SH, + * effectively waiting for the thaw on the node who holds it in EX. + * Once thawed, the work func acquires the freeze glock in + * SH and everybody goes back to thawed. + */ + if (gl->gl_state == LM_ST_SHARED && !gfs2_withdrawn(sdp)) { atomic_set(&sdp->sd_freeze_state, SFS_STARTING_FREEZE); error = freeze_super(sdp->sd_vfs); if (error) {