From: Joe Perches <joe@perches.com>
Subject: Re: [PATCH V6] UBI: Extend UBI layer debug/messaging capabilities
Date: Mon, 10 Nov 2014 09:57:53 -0800
Message-ID: <1415642273.8868.8.camel@perches.com>
References: <1415023112-21704-1-git-send-email-tlinder@codeaurora.org>
	 <5460F7D8.2030100@nod.at>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from smtprelay0030.hostedemail.com ([216.40.44.30]:53826 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1752910AbaKJR55 (ORCPT
	<rfc822;linux-arm-msm@vger.kernel.org>);
	Mon, 10 Nov 2014 12:57:57 -0500
In-Reply-To: <5460F7D8.2030100@nod.at>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Richard Weinberger <richard@nod.at>
Cc: Tanya Brokhman <tlinder@codeaurora.org>, dedekind1@gmail.com, linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, Artem Bityutskiy <artem.bityutskiy@linux.intel.com>, David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, open list <linux-kernel@vger.kernel.org>

On Mon, 2014-11-10 at 18:37 +0100, Richard Weinberger wrote:
> Am 03.11.2014 um 14:58 schrieb Tanya Brokhman:
> > If there is more then one UBI device mounted, there is no way to
> > distinguish between messages from different UBI devices.
> > Add device number to all ubi layer message types.

Adding "error" and "warning" to the message logs is
duplicative to the KERN_<LEVEL> logging information.

> > Changes from V5:
> > 	- Added ptr verification @ ubi_err/ubi_msg/ubi_warn
> > 	Removed extra printing of ubi number
> > 	Removed new messages.

Did you all ever look at what I posted?

https://lkml.org/lkml/2014/10/14/280

smaller code, consistent prefixing, consistent with
typical kernel style, etc.

> While testing I noticed that the log output looks quite different.
> 
> e.g.
> [   26.564111] UBI-0: ubi_attach_mtd_dev:default fastmap pool size: 256
> [   26.565438] UBI-0: ubi_attach_mtd_dev:default fastmap WL pool size: 128

If __func__ is really desired, it's generally better to
put a space after the "%s:", __func__ so there's visual
separation between the prefixes and the content.

I agree that emitting function names isn't particularly
useful.

(and Richard, do please remember to trim your posts,
 you sent > 100KB of unnecessary quoted stuff)