From: Bob Peterson Date: Mon, 16 Apr 2018 12:39:23 -0400 (EDT) Subject: [Cluster-devel] [PATCH] gfs2: Remove sdp->sd_jheightsize In-Reply-To: <20180413130117.12866-1-agruenba@redhat.com> References: <20180413130117.12866-1-agruenba@redhat.com> Message-ID: <1417483905.19933300.1523896763401.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- > GFS2 keeps two arrarys in the superblock that define the maximum size of > an inode depending on the inode's height: sdp->sd_heightsize defines the > heights in units of sb->s_blocksize; sdp->sd_jheightsize defines them in > units of sb->s_blocksize - sizeof(struct gfs2_meta_header). These > arrays are used to determine when additional layers of indirect blocks > are needed. The second array is used for directories which have an > additional gfs2_meta_header at the beginning of each block. > > Distinguishing between these two cases makes no sense: the height > required for representing N blocks will come out the same no matter if > the calculation is done in gross (sb->s_blocksize) or net > (sb->s_blocksize - sizeof(struct gfs2_meta_header)) units. > > Stuffed directories don't have an additional gfs2_meta_header, but the > stuffed case is handled separately for both files and directories, > anyway. > > Remove the unncessary sdp->sd_jheightsize array. > > Signed-off-by: Andreas Gruenbacher > --- Hi, Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=9a38662ba4e2682f3f3e9f3ce02a243b837aa8c6 Regards, Bob Peterson Red Hat File Systems