From: Mario Kleiner Subject: [PATCH 1/2] present: Avoid crashes in DebugPresent(), a bit more info. Date: Tue, 2 Dec 2014 20:08:47 +0100 Message-ID: <1417547329-9352-2-git-send-email-mario.kleiner.de@gmail.com> References: <1417547329-9352-1-git-send-email-mario.kleiner.de@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 07FBA6F9AE for ; Tue, 2 Dec 2014 11:09:27 -0800 (PST) Received: by mail-wi0-f175.google.com with SMTP id l15so29122052wiw.14 for ; Tue, 02 Dec 2014 11:09:26 -0800 (PST) In-Reply-To: <1417547329-9352-1-git-send-email-mario.kleiner.de@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: keithp@keithp.com, axel.davy@ens.fr, mario.kleiner.de@gmail.com, jamey@minilop.net, chris@chris-wilson.co.uk, skeggsb@gmail.com Cc: maarten.lankhorst@canonical.com, intel-gfx@lists.freedesktop.org, xorg-devel@lists.x.org, Theo0x48@gmail.com, jcristau@debian.org List-Id: intel-gfx@lists.freedesktop.org RGVidWdQcmVzZW50KCkgY3Jhc2hlZCB0aGUgc2VydmVyIHdoZW4gYSBkcmkzIGRyYXdhYmxlCndh cyBjbG9zZWQgd2hpbGUgYSBwYWdlZmxpcHBlZCBwcmVzZW50IHdhcyBzdGlsbCBwZW5kaW5nLApk dWUgdG8gdmJsYW5rLT53aW5kb3ctPiBOdWxsLVB0ciBkZXJlZiwgc28gZGVidWcgYnVpbGRzCmNh dXNlZCBuZXcgcHJvYmxlbXMgdG8gZGVidWcuCgpFLmcuLAoKZ2xYU3dhcEJ1ZmZlcnMoLi4uKTsK Z2xYRGVzdHJveVdpbmRvdyguLi4pOwotPiBQYWdlZmxpcCBmb3Igbm9uLWV4aXN0ZW50IHdpbmRv dyBjb21wbGV0ZXMgLT4gYm9vbS4KCkFsc28gb2Z0ZW4gaGFwcGVucyB3aGVuIHN3aXRjaGluZyBk ZXNrdG9wIGNvbXBvc2l0b3Igb24vb2ZmCmR1ZSB0byBQcmVzZW50IHVuZmxpcHMsIG9yIHdoZW4g bG9nZ2luZyBvdXQgb2Ygc2Vzc2lvbi4KCkFsc28gYWRkIGluZm8gaWYgYSBQcmVzZW50IGlzIHF1 ZXVlZCBmb3IgY29weXN3YXAgb3IgcGFnZWZsaXAsCmlmIHRoZSBwcmVzZW50IGlzIHZzeW5jZWQs IGFuZCB0aGUgc2VyaWFsIG5vIG9mIHRoZSBQcmVzZW50CnJlcXVlc3QsIHRvIGFpZCBkZWJ1Z2dp bmcgb2YgcGFnZWZsaXAgYW5kIHZzeW5jIGlzc3Vlcy4gVGhlCnNlcmlhbCBudW1iZXIgaXMgdXNl ZnVsIGFzIE1lc2EncyBkcmkzL3ByZXNlbnQgYmFja2VuZCBlbmNvZGVzCml0cyBzZW5kU0JDIGlu IHRoZSBzZXJpYWwgbnVtYmVyLCBzbyBvbmUgY2FuIGVhc2lseSBjb3JyZWxhdGUKc2VydmVyIGRl YnVnIG91dHB1dCB3aXRoIE1lc2EgYW5kIHdpdGggdGhlIFNCQyB2YWx1ZXMgcmV0dXJuZWQKdG8g YWN0dWFsIE9wZW5HTCBjbGllbnQgYXBwbGljYXRpb25zIHZpYSBPTUxfc3luY19jb250cm9sIGFu ZApJTlRFTF9zd2FwX2V2ZW50cyBleHRlbnNpb24sIG1ha2VzIGRlYnVnZ2luZyBxdWl0ZSBhIGJp dCBtb3JlCmVhc3kuCgpQbGVhc2UgYWxzbyBjaGVycnktcGljayB0aGlzIGZvciBhIDEuMTYueCBz dGFibGUgdXBkYXRlLgoKU2lnbmVkLW9mZi1ieTogTWFyaW8gS2xlaW5lciA8bWFyaW8ua2xlaW5l ci5kZUBnbWFpbC5jb20+Ci0tLQogcHJlc2VudC9wcmVzZW50LmMgfCA4ICsrKystLS0tCiAxIGZp bGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L3ByZXNlbnQvcHJlc2VudC5jIGIvcHJlc2VudC9wcmVzZW50LmMKaW5kZXggYWM5MDQ3ZS4uZTVk M2ZkNSAxMDA2NDQKLS0tIGEvcHJlc2VudC9wcmVzZW50LmMKKysrIGIvcHJlc2VudC9wcmVzZW50 LmMKQEAgLTQ0MCw3ICs0NDAsNyBAQCBwcmVzZW50X2ZsaXBfbm90aWZ5KHByZXNlbnRfdmJsYW5r X3B0ciB2YmxhbmssIHVpbnQ2NF90IHVzdCwgdWludDY0X3QgY3J0Y19tc2MpCiAgICAgRGVidWdQ cmVzZW50KCgiXHRuICVsbGQgJXAgJThsbGQ6ICUwOGx4IC0+ICUwOGx4XG4iLAogICAgICAgICAg ICAgICAgICAgdmJsYW5rLT5ldmVudF9pZCwgdmJsYW5rLCB2YmxhbmstPnRhcmdldF9tc2MsCiAg ICAgICAgICAgICAgICAgICB2YmxhbmstPnBpeG1hcCA/IHZibGFuay0+cGl4bWFwLT5kcmF3YWJs ZS5pZCA6IDAsCi0gICAgICAgICAgICAgICAgICB2YmxhbmstPndpbmRvdy0+ZHJhd2FibGUuaWQp KTsKKyAgICAgICAgICAgICAgICAgIHZibGFuay0+d2luZG93ID8gdmJsYW5rLT53aW5kb3ctPmRy YXdhYmxlLmlkIDogMCkpOwogCiAgICAgYXNzZXJ0ICh2YmxhbmsgPT0gc2NyZWVuX3ByaXYtPmZs aXBfcGVuZGluZyk7CiAKQEAgLTg1OSwxMCArODU5LDEwIEBAIHByZXNlbnRfcGl4bWFwKFdpbmRv d1B0ciB3aW5kb3csCiAgICAgfQogCiAgICAgaWYgKHBpeG1hcCkKLSAgICAgICAgRGVidWdQcmVz ZW50KCgicSAlbGxkICVwICU4bGxkOiAlMDhseCAtPiAlMDhseCAoY3J0YyAlcClcbiIsCisgICAg ICAgIERlYnVnUHJlc2VudCgoInEgJWxsZCAlcCAlOGxsZDogJTA4bHggLT4gJTA4bHggKGNydGMg JXApIGZsaXAgJWQgdnN5bmMgJWQgc2VyaWFsICVkXG4iLAogICAgICAgICAgICAgICAgICAgICAg IHZibGFuay0+ZXZlbnRfaWQsIHZibGFuaywgdGFyZ2V0X21zYywKICAgICAgICAgICAgICAgICAg ICAgICB2YmxhbmstPnBpeG1hcC0+ZHJhd2FibGUuaWQsIHZibGFuay0+d2luZG93LT5kcmF3YWJs ZS5pZCwKLSAgICAgICAgICAgICAgICAgICAgICB0YXJnZXRfY3J0YykpOworICAgICAgICAgICAg ICAgICAgICAgIHRhcmdldF9jcnRjLCB2YmxhbmstPmZsaXAsIHZibGFuay0+c3luY19mbGlwLCB2 YmxhbmstPnNlcmlhbCkpOwogCiAgICAgeG9yZ19saXN0X2FkZCgmdmJsYW5rLT5ldmVudF9xdWV1 ZSwgJnByZXNlbnRfZXhlY19xdWV1ZSk7CiAgICAgdmJsYW5rLT5xdWV1ZWQgPSBUUlVFOwpAQCAt OTU1LDcgKzk1NSw3IEBAIHByZXNlbnRfdmJsYW5rX2Rlc3Ryb3kocHJlc2VudF92YmxhbmtfcHRy IHZibGFuaykKICAgICBEZWJ1Z1ByZXNlbnQoKCJcdGQgJWxsZCAlcCAlOGxsZDogJTA4bHggLT4g JTA4bHhcbiIsCiAgICAgICAgICAgICAgICAgICB2YmxhbmstPmV2ZW50X2lkLCB2YmxhbmssIHZi bGFuay0+dGFyZ2V0X21zYywKICAgICAgICAgICAgICAgICAgIHZibGFuay0+cGl4bWFwID8gdmJs YW5rLT5waXhtYXAtPmRyYXdhYmxlLmlkIDogMCwKLSAgICAgICAgICAgICAgICAgIHZibGFuay0+ d2luZG93LT5kcmF3YWJsZS5pZCkpOworICAgICAgICAgICAgICAgICAgdmJsYW5rLT53aW5kb3cg PyB2YmxhbmstPndpbmRvdy0+ZHJhd2FibGUuaWQgOiAwKSk7CiAKICAgICAvKiBEcm9wIHBpeG1h cCByZWZlcmVuY2UgKi8KICAgICBpZiAodmJsYW5rLT5waXhtYXApCi0tIAoxLjkuMQoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK