Return-Path: From: jun.zhang@intel.com To: mingo@redhat.com, peterz@infradead.org Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, zhang jun , Chuansheng Liu , Changcheng Liu , Hillf Danton , Vincent Guittot Subject: [PATCH] sched/fair: fix find_idlest_cpu return -1 Date: Fri, 5 Dec 2014 13:58:01 +0800 Message-Id: <1417759082-28385-1-git-send-email-jun.zhang@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: From: zhang jun find_idlest_cpu return -1 is not reasonable, set default value to this_cpu. Signed-off-by: zhang jun Signed-off-by: Chuansheng Liu Signed-off-by: Changcheng Liu Cc: Hillf Danton Cc: Vincent Guittot Cc: # 3.14.25 --- kernel/sched/fair.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 9b4c4f3..9d18887 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -4151,7 +4151,7 @@ static int find_idlest_cpu(struct sched_group *group, struct task_struct *p, int this_cpu) { unsigned long load, min_load = ULONG_MAX; - int idlest = -1; + int idlest = this_cpu; int i; /* Traverse only the allowed CPUs */ @@ -4284,7 +4284,7 @@ select_task_rq_fair(struct task_struct *p, int prev_cpu, int sd_flag, int wake_f } new_cpu = find_idlest_cpu(group, p, cpu); - if (new_cpu == -1 || new_cpu == cpu) { + if (new_cpu == cpu) { /* Now try balancing at a lower domain level of cpu */ sd = sd->child; continue; -- 1.7.9.5