From: Sjoerd Simons Date: Tue, 16 Dec 2014 09:03:37 +0100 Subject: [U-Boot] [PATCH] cros-ec-keyboard: Synchronize DT binding from linux In-Reply-To: <20141215223429.GB27866@amd> References: <1417102448-5637-1-git-send-email-sjoerd.simons@collabora.co.uk> <20141215223429.GB27866@amd> Message-ID: <1418717017.5286.28.camel@collabora.co.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 2014-12-15 at 23:34 +0100, Pavel Machek wrote: > On Thu 2014-11-27 16:34:08, Sjoerd Simons wrote: > > The ChromeOS EC keyboard is used by various different chromebooks. Peach > > pi being the third board in the u-boot tree to use it (snow and peach > > pit the other two). Rather then embedding the same big DT node in the > > peach-pi DT again, copy the dtsi snippit & bindings documentation from > > linux and include it in all 3 boards. > > > > This slightly changes the dt bindings in u-boot: > ... > > * google,repeat-delay-ms and google,repeat-rate-ms are no longer used > > and replaced by hardcoded values (similar to tegra kbc) > > If more than one board needs this (and it clearly does) it would be > good to make the binding "official"...? I guess that means talking to > linux Documentation/devicetree maintainers... Device tree is for describing hardware, while repeat rate & delay are user preferences, not something inherent to the hardware. As such, those properties do not belong in device-tree in the first place. Fwiw, Linux by default uses a delay of 250ms and a period of 33ms unless the driver handles auto-repeat (e.g. for PS2 which does repeat in hardware). If your goal is to fix the hardcoding of these values in various drivers, it's probably better to make u-boot input core have sane defaults for repeat rather then pushing it out into device-tree. -- Sjoerd Simons Collabora Ltd. -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 6170 bytes Desc: not available URL: