From: Joe Perches Date: Fri, 19 Dec 2014 12:26:31 +0000 Subject: Re: [PATCH 3/3] [SCSI] mpt2sas: Remove unnecessary use of a boolean variable Message-Id: <1418991991.25129.10.camel@perches.com> List-Id: References: <20141219111345.GA19938@sloth> In-Reply-To: <20141219111345.GA19938@sloth> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Quentin Lambert Cc: Nagalakshmi Nandigama , Praveen Krishnamoorthy , Sreekanth Reddy , Abhijit Mahajan , "James E.J. Bottomley" , MPT-FusionLinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, 2014-12-19 at 12:13 +0100, Quentin Lambert wrote: [] > diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c [] > @@ -1414,12 +1414,8 @@ _base_enable_msix(struct MPT2SAS_ADAPTER *ioc) > struct msix_entry *entries, *a; > int r; > int i; > - u8 try_msix = 0; > > - if (msix_disable = -1 || msix_disable = 0) > - try_msix = 1; > - > - if (!try_msix) > + if (msix_disable != -1 || msix_disable != 0) > goto try_ioapic; logic not the same. Now needs && not ||