From: Bartosz Golaszewski Date: Mon, 12 Jan 2015 13:47:22 +0000 Subject: [lm-sensors] [PATCH 2/2] hwmon: (ina2xx) use DIV_ROUND_CLOSEST() to avoid rounding errors Message-Id: <1421070442-9635-3-git-send-email-bgolaszewski@baylibre.com> List-Id: References: <1421070442-9635-1-git-send-email-bgolaszewski@baylibre.com> In-Reply-To: <1421070442-9635-1-git-send-email-bgolaszewski@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guenter Roeck Cc: LKML , Benoit Cousson , Patrick Titiano , LM Sensors , Bartosz Golaszewski Use DIV_ROUND_CLOSEST() when dealing with the calibration values to make the calculations less error prone. Signed-off-by: Bartosz Golaszewski --- drivers/hwmon/ina2xx.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c index ae110c5..611ec4e 100644 --- a/drivers/hwmon/ina2xx.c +++ b/drivers/hwmon/ina2xx.c @@ -186,8 +186,11 @@ static void ina226_set_update_interval(struct ina2xx_data *data) static int ina2xx_calibrate(struct ina2xx_data *data) { - return i2c_smbus_write_word_swapped(data->client, INA2XX_CALIBRATION, - data->config->calibration_factor / data->rshunt); + u16 val = DIV_ROUND_CLOSEST(data->config->calibration_factor, + data->rshunt); + + return i2c_smbus_write_word_swapped(data->client, + INA2XX_CALIBRATION, val); } /* @@ -307,7 +310,8 @@ static int ina2xx_get_value(struct ina2xx_data *data, u8 reg) val = (s16)data->regs[reg]; break; case INA2XX_CALIBRATION: - val = data->config->calibration_factor / data->regs[reg]; + val = DIV_ROUND_CLOSEST(data->config->calibration_factor, + data->regs[reg]); break; default: /* programmer goofed */ -- 2.1.3 _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors