From: Jan Kara Subject: [PATCH] fs: Check return value of ->show_devname Date: Wed, 21 Jan 2015 13:46:51 +0100 Message-ID: <1421844412-15398-1-git-send-email-jack@suse.cz> Cc: linux-fsdevel@vger.kernel.org, Andrew Morton , Jan Kara To: Al Viro Return-path: Received: from cantor2.suse.de ([195.135.220.15]:52351 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751939AbbAUMq7 (ORCPT ); Wed, 21 Jan 2015 07:46:59 -0500 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: show_vfsstat() isn't checking the return value of ->show_devname(). Check it and bail out properly. Coverity-id: 1260113 Signed-off-by: Jan Kara --- fs/proc_namespace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/proc_namespace.c b/fs/proc_namespace.c index 0f96f71ab32b..a29f17a9070f 100644 --- a/fs/proc_namespace.c +++ b/fs/proc_namespace.c @@ -195,6 +195,8 @@ static int show_vfsstat(struct seq_file *m, struct vfsmount *mnt) if (sb->s_op->show_devname) { seq_puts(m, "device "); err = sb->s_op->show_devname(m, mnt_path.dentry); + if (err) + goto out; } else { if (r->mnt_devname) { seq_puts(m, "device "); -- 2.1.2