Received: from eggs.gnu.org ([2001:4830:134:3::10]:49279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLyqN-0002Ln-I1 for qemu-devel@nongnu.org; Thu, 12 Feb 2015 13:50:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLyqH-0006Ju-Pi for qemu-devel@nongnu.org; Thu, 12 Feb 2015 13:50:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLyqH-0006Jd-JE for qemu-devel@nongnu.org; Thu, 12 Feb 2015 13:50:25 -0500 From: Laszlo Ersek Date: Thu, 12 Feb 2015 19:50:13 +0100 Message-Id: <1423767013-22935-1-git-send-email-lersek@redhat.com> Subject: [Qemu-devel] [PATCH] hw/arm/virt: "bus-range"/end is off by one List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: agraf@suse.de, peter.maydell@linaro.org, qemu-devel@nongnu.org, lersek@redhat.com According to "PCI Bus Binding to IEEE Std 1275-1994", 3.1.2. Bus-specific Properties for Bus Nodes, the second integer in "bus-range" is an inclusive limit. This seems to be consistent with several *.dtsi files in the kernel tree, where examples like bus-range = <0 0>; are visible. In addition, the loop in gen_pci_parse_map_cfg_windows() [drivers/pci/host/pci-host-generic.c] uses "bus_range->end" as an inclusive limit. Signed-off-by: Laszlo Ersek --- Notes: Applies on top of target-arm.next. hw/arm/virt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index a2a5c96..ee77093 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -693,7 +693,8 @@ static void create_pcie(const VirtBoardInfo *vbi, qemu_irq *pic, qemu_fdt_setprop_string(vbi->fdt, nodename, "device_type", "pci"); qemu_fdt_setprop_cell(vbi->fdt, nodename, "#address-cells", 3); qemu_fdt_setprop_cell(vbi->fdt, nodename, "#size-cells", 2); - qemu_fdt_setprop_cells(vbi->fdt, nodename, "bus-range", 0, nr_pcie_buses); + qemu_fdt_setprop_cells(vbi->fdt, nodename, "bus-range", 0, + nr_pcie_buses - 1); qemu_fdt_setprop_sized_cells(vbi->fdt, nodename, "reg", 2, base_ecam, 2, size_ecam); -- 1.8.3.1