Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mail.openembedded.org (Postfix) with ESMTP id 5F76B6017E for ; Fri, 6 Mar 2015 14:03:40 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 06 Mar 2015 06:00:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,353,1422950400"; d="scan'208";a="687977205" Received: from bottazzini-thinkpad-t430.bz.intel.com (HELO [10.218.99.51]) ([10.218.99.51]) by fmsmga002.fm.intel.com with ESMTP; 06 Mar 2015 06:03:33 -0800 Message-ID: <1425650611.2831.20.camel@bottazzini-ThinkPad-T430> From: "Bottazzini, Bruno" To: Anders Darander Date: Fri, 06 Mar 2015 11:03:31 -0300 In-Reply-To: <20150306082330.GA14309@ad.chargestorm.se> References: <1425504462-6979-1-git-send-email-bruno.bottazzini@intel.com> <1425504462-6979-4-git-send-email-bruno.bottazzini@intel.com> <20150305142802.GA6833@ad.chargestorm.se> <1425572096.2831.16.camel@bottazzini-ThinkPad-T430> <20150306082330.GA14309@ad.chargestorm.se> X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 3/3] systemd: split modules into packages X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Mar 2015 14:03:44 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Sex, 2015-03-06 at 09:23 +0100, Anders Darander wrote: > * Bottazzini, Bruno [150305 17:15]: > > > On Qui, 2015-03-05 at 15:28 +0100, Anders Darander wrote: > > > > Just a quick question before I look into the patch in more detail. > > > > Is the new setting of PACKAGECONFIG consistent with how systemd was > > > built previously? I guess it is. > > > Hi Anders, > > > it is consistent with how systemd was built previously. If you apply the > > patch and bitbake it. Systemd will be built and shipped normally. > > > But now it will give some options on how to customize it by excluding > > packages you don't want to be with systemd. > > Nice, I'm really liking this! That's something I've planned on doing > myself for a while. > > > > Another comment, you should remove the dependcies that gets added using > > > PACKAGECONFIG from DEPENDS, e.g. acl etc. (Or are they required > > > nevertheless?) > > > You mean I should do the following ? > > - PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl" > > + PACKAGECONFIG[acl] = "--enable-acl,--disable-acl" > > No, I meant to remove them from the long > DEPENDS = "kmod docbook-sgml-dtd-4.1-native intltool-native gperf-native acl readline dbus libcap libcgroup glib-2.0 qemu-native util-linux" > line. (Unless I overlooked that part in your patch?) > > > If I get what you said correctly, yes they are required. > > What I meant, was thas unless e.g. acl is required even when building > with --disable-acl, it's better to add the acl dependency in the > PACKAGECONFIG like you to. Though, at the same time, remove acl from the > long DEPENDS-line. (As otherwise we'll build acl anyway). Anders, You are right. It is not needed to specify the libs on depends. I have removed it and as soon as we review the whole patch I will send a new version with this corrected Best Regards, Bruno Bottazzini > > Cheers, > Anders >