From: Tiejun Chen Subject: [PATCH] tools/libxl: cleanup one libxl__calloc() usage Date: Tue, 10 Mar 2015 14:28:16 +0800 Message-ID: <1425968896-27199-1-git-send-email-tiejun.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Its pointless because internally, libxl__calloc() would always terminate program execution if failed, libxl__calloc() | + void *ptr = calloc(nmemb, size); + if (!ptr) libxl__alloc_failed(CTX, __func__, nmemb, size); | + _exit(-1); Signed-off-by: Tiejun Chen --- tools/libxl/libxl_dm.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index 8599a6a..cb006df 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm.c @@ -1175,10 +1175,6 @@ static void spawn_stub_launch_dm(libxl__egc *egc, num_console++; console = libxl__calloc(gc, num_console, sizeof(libxl__device_console)); - if (!console) { - ret = ERROR_NOMEM; - goto out; - } for (i = 0; i < num_console; i++) { libxl__device device; -- 1.9.1