Received-SPF: pass (google.com: domain of cristina.opriceana@gmail.com designates 2a00:1450:400c:c03::234 as permitted sender) client-ip=2a00:1450:400c:c03::234;
Message-ID: <1426151512.6120.2.camel@Inspiron>
Subject: Re: [Outreachy kernel] [PATCH 3/3] Staging: rtl8712: Remove
 unnecessary variables
From: Cristina Opriceana <cristina.opriceana@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: outreachy-kernel@googlegroups.com
Date: Thu, 12 Mar 2015 11:11:52 +0200
In-Reply-To: <2934799.MUPJAeKi6D@wuerfel>
References: <cover.1426126379.git.cristina.opriceana@gmail.com>
	 <61eb27f3cd4bb009cbbd1c6d4bfd9b89a109fd36.1426126379.git.cristina.opriceana@gmail.com>
	 <2934799.MUPJAeKi6D@wuerfel>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit


> When a local function unconditionally returns success, it's often a good
> idea to change the prototype so it returns void.
> 
> That would also improve it a bit by avoiding the non-standard _SUCCESS
> return code. The kernel convention normally is to return '0' for success
> and a negative error numer (e.g. -ENXIO) in case of an error, with a
> type of 'int'. Changing all the return codes in this driver would
> of course be a separate patch.

Indeed, _SUCCESS doesn't look well there. I'll check this out.


Thanks, 
Cristina