Received-SPF: pass (google.com: domain of cristina.opriceana@gmail.com designates 2a00:1450:400c:c05::22c as permitted sender) client-ip=2a00:1450:400c:c05::22c;
Message-ID: <1426340621.6721.11.camel@Inspiron>
Subject: Re: [Outreachy kernel] [PATCH 1/3] Staging: rtl8188eu: Bool tests
 don't need comparisons
From: Cristina Opriceana <cristina.opriceana@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: outreachy-kernel@googlegroups.com
Date: Sat, 14 Mar 2015 15:43:41 +0200
In-Reply-To: <alpine.DEB.2.02.1503141053470.2075@localhost6.localdomain6>
References: <cover.1426273386.git.cristina.opriceana@gmail.com>
	 <89c63fedf7d2979ad94f85a601bc6d8ef80fe142.1426273386.git.cristina.opriceana@gmail.com>
	 <alpine.DEB.2.02.1503141053470.2075@localhost6.localdomain6>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit


> > diff --git a/drivers/staging/rtl8188eu/hal/rf_cfg.c b/drivers/staging/rtl8188eu/hal/rf_cfg.c
> > index 455ecdc..954cade 100644
> > --- a/drivers/staging/rtl8188eu/hal/rf_cfg.c
> > +++ b/drivers/staging/rtl8188eu/hal/rf_cfg.c
> > @@ -295,7 +295,7 @@ static bool rf6052_conf_para(struct adapter *adapt)
> >  			break;
> >  		}
> >  
> > -		if (rtstatus != true)
> > +		if (!rtstatus)
> >  			return false;
> 
> Looking at this code a bit, I can't see how rtstatus could be anything 
> other than true.  So perhaps the test, and even the variable, is not 
> needed?
> 
> julia
> 

I had a look at it. rtstatus is only modified in
  rtstatus = rtl88e_phy_config_rf_with_headerfile(adapt);

And indeed, this function returns only true.
I will make another patch removing unnecessary code.

 Thanks,
 Cristina