From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 2/3] tools/libxl/libxl_cpuid.c: Fix leak of
 resstr on error path
Date: Wed, 18 Mar 2015 12:31:49 +0000
Message-ID: <1426681909.18247.365.camel@citrix.com>
References: <1426500377-40643-1-git-send-email-pramod.devendra@citrix.com>
	<20150317154416.GC20522@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YYD8d-0000XW-Eb
	for xen-devel@lists.xenproject.org; Wed, 18 Mar 2015 12:31:55 +0000
In-Reply-To: <20150317154416.GC20522@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, PRAMOD DEVENDRA <pramod.devendra@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-03-17 at 15:44 +0000, Wei Liu wrote:
> On Mon, Mar 16, 2015 at 10:06:17AM +0000, PRAMOD DEVENDRA wrote:
> > From: Pramod Devendra <pramod.devendra@citrix.com>
> > 
> > Signed-off-by: Pramod Devendra <pramod.devendra@citrix.com>
> > CC: Ian Jackson <ian.jackson@eu.citrix.com>
> > CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > CC: Ian Campbell <ian.campbell@citrix.com>
> > CC: Wei Liu <wei.liu2@citrix.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>

Applied.

> >      resstr = entry->policy[flag->reg - 1];
> > -    if (resstr == NULL) {
> > -        resstr = strdup("xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx");
> > -    }
> 
> Minor nit. I would prefer "resstr = " be grouped with the code you
> moved. No need to resend though.

Do you mean the restr = entry->... bit?