Received: from eggs.gnu.org ([2001:4830:134:3::10]:35754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYoLH-0006rM-Fw for qemu-devel@nongnu.org; Fri, 20 Mar 2015 00:15:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYoLD-0004wX-DC for qemu-devel@nongnu.org; Fri, 20 Mar 2015 00:15:27 -0400 Received: from mail-pd0-x234.google.com ([2607:f8b0:400e:c02::234]:35929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYoLD-0004wL-5z for qemu-devel@nongnu.org; Fri, 20 Mar 2015 00:15:23 -0400 Received: by pdbcz9 with SMTP id cz9so96461003pdb.3 for ; Thu, 19 Mar 2015 21:15:21 -0700 (PDT) Sender: Lin Ma From: Lin Ma Date: Fri, 20 Mar 2015 12:14:58 +0800 Message-Id: <1426824898-9936-1-git-send-email-lma@suse.com> Subject: [Qemu-devel] [PATCH] object_del: Prevent removing an in-use memory backend object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, imammedo@redhat.com Cc: pbonzini@redhat.com, Lin Ma showing a memory device whose memdev is removed leads an assert: (qemu) object_add memory-backend-ram,id=ram0,size=128M (qemu) device_add pc-dimm,id=d0,memdev=ram0 (qemu) object_del ram0 (qemu) info memory-devices ** ERROR:qom/object.c:1274:object_get_canonical_path_component:\ assertion failed: (obj->parent != NULL) Aborted The patch prevents removing an in-use mem backend and outputs an error msg. Signed-off-by: Lin Ma --- qmp.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/qmp.c b/qmp.c index c479e77..0086e2d 100644 --- a/qmp.c +++ b/qmp.c @@ -704,6 +704,7 @@ void qmp_object_del(const char *id, Error **errp) { Object *container; Object *obj; + const char *typename; container = container_get(object_get_root(), "/objects"); obj = object_resolve_path_component(container, id); @@ -711,6 +712,19 @@ void qmp_object_del(const char *id, Error **errp) error_setg(errp, "object id not found"); return; } + + typename = object_class_get_name(object_class_get_parent(\ + object_get_class(OBJECT(obj)))); + if (strcmp(typename, TYPE_MEMORY_BACKEND) == 0 ) { + MemoryRegion *mr; + mr = host_memory_backend_get_memory(MEMORY_BACKEND(obj), errp); + if (memory_region_is_mapped(mr)) { + char *path = object_get_canonical_path_component(obj); + error_setg(errp, "memdev %s is in used.", path); + g_free(path); + return; + } + } object_unparent(obj); } -- 2.1.4