From: Scott Wood Date: Fri, 20 Mar 2015 16:33:52 -0500 Subject: [U-Boot] [PATCH v4 24/28] armv8/ls2085aqds: NAND boot support In-Reply-To: <550C8FD7.5080208@freescale.com> References: <1426879262-32573-1-git-send-email-yorksun@freescale.com> <1426879262-32573-2-git-send-email-yorksun@freescale.com> <1426886140.27998.206.camel@freescale.com> <550C8FD7.5080208@freescale.com> Message-ID: <1426887232.27998.218.camel@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, 2015-03-20 at 14:23 -0700, York Sun wrote: > > On 03/20/2015 02:15 PM, Scott Wood wrote: > > On Fri, 2015-03-20 at 12:21 -0700, York Sun wrote: > >> From: Scott Wood > >> > >> This adds NAND boot support for LS2085AQDS, using SPL framework. > >> > >> To form a NAND image, append u-boot-with-spl.bin after a proper > >> nand boot RCW and flash to the beginning of NAND. > > > > Do we want to do it this way, or should we keep the RCW in a separate > > block? > > I would like to see RCW in a separated block. OK. In that case the offsets in this patch will need to change. > > What constitutes a "proper nand boot RCW" (those were not my words)? > > There are details in this patch regarding offsets that need to match > > details in the PBI (which is more than just RCW). > > It is not your original words. Yours was "To form a NAND image, append > u-boot-with-spl.bin after PBL_0x3_0x07_1333_nand.bin and flash to the beginning > of NAND.". I try to make the message generic. A proper nand boot RCW means the > RCW should contains PBI commands to set bootloc and block copy the image. Since > RCW is not in the scope of u-boot, I cannot refer to any specific file. Yes, I know you can't refer to the file, but it needs to be made clear what the expectations of that PBI file are. > Do you want to include an RCW file into u-boot, like those for powerpc boards? Not really. I'd rather have rcw.git published for all use cases (like http://git.freescale.com/git/cgit.cgi/layerscape/ls1021a/rcw.git/ but updated for ls2085a and without the repository being chip-specific (at least in name)). On PPC we had to have U-Boot do it because the U-Boot image itself had to be encoded in the PBI. That thankfully isn't the case here. -Scott