From: Sanidhya Kashyap Subject: [PATCH] affs: kstrdup() memory handling Date: Sat, 21 Mar 2015 12:46:24 -0400 Message-ID: <1426956384-22742-1-git-send-email-sanidhya.gatech@gmail.com> Cc: taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu, blee@gatech.edu, csong84@gatech.edu, Sanidhya Kashyap To: akpm@linux-foundation.org, fabf@skynet.be, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org There is a possibility of kstrdup() failure upon memory pressure. Therefore, returning ENOMEM even for new_opts. Signed-off-by: Sanidhya Kashyap --- fs/affs/super.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/affs/super.c b/fs/affs/super.c index 4cf0e91..f4d0d36 100644 --- a/fs/affs/super.c +++ b/fs/affs/super.c @@ -524,6 +524,10 @@ affs_remount(struct super_block *sb, int *flags, char *data) char volume[32]; char *prefix = NULL; + + if (!new_opts) + return -ENOMEM; + pr_debug("%s(flags=0x%x,opts=\"%s\")\n", __func__, *flags, data); sync_filesystem(sb); -- 2.1.0