From: Scott Wood Date: Mon, 23 Mar 2015 17:08:41 -0500 Subject: [U-Boot] [PATCH v4 20/28] armv8/ls2085ardb: Add support of LS2085ARDB platform In-Reply-To: <55108DF8.9070407@freescale.com> References: <1426897768-22798-1-git-send-email-yorksun@freescale.com> <1426898023.27998.254.camel@freescale.com> <550CCD84.6010104@freescale.com> <1427148169.22867.12.camel@freescale.com> <55108DF8.9070407@freescale.com> Message-ID: <1427148521.22867.16.camel@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 2015-03-23 at 15:04 -0700, York Sun wrote: > > On 03/23/2015 03:02 PM, Scott Wood wrote: > > On Fri, 2015-03-20 at 18:46 -0700, York Sun wrote: > >> > >> On 03/20/2015 05:33 PM, Scott Wood wrote: > >>> On Fri, 2015-03-20 at 17:29 -0700, York Sun wrote: > >>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > >>>> index f4a7851..7478eb4 100644 > >>>> --- a/arch/arm/Kconfig > >>>> +++ b/arch/arm/Kconfig > >>>> @@ -658,6 +658,16 @@ config TARGET_LS2085AQDS > >>>> development platform that supports the QorIQ LS2085A > >>>> Layerscape Architecture processor. > >>>> > >>>> +config TARGET_LS2085ARDB > >>>> + bool "Support ls2085ardb" > >>>> + select ARM64 > >>>> + select ARMV8_MULTIENTRY > >>>> + help > >>>> + Support for Freescale LS2085ARDB platform. > >>>> + The LS2080A Reference design board (RDB) is a high-performance > >>>> + development platform that supports the QorIQ LS2085A > >>>> + LayerScape Architecture processor. > >>>> + > >>> > >>> s/LayerScape/Layerscape/ > >>> > >>>> diff --git a/board/freescale/ls2085aqds/README b/board/freescale/ls2085ardb/README > >>>> similarity index 73% > >>>> copy from board/freescale/ls2085aqds/README > >>>> copy to board/freescale/ls2085ardb/README > >>>> index a4d7b53..cfd5185 100644 > >>>> --- a/board/freescale/ls2085aqds/README > >>>> +++ b/board/freescale/ls2085ardb/README > >>>> @@ -1,10 +1,8 @@ > >>>> Overview > >>>> -------- > >>>> -The LS2080A Development System (QDS) is a high-performance computing, > >>>> -evaluation, and development platform that supports the QorIQ LS2080A > >>>> -LayerScape Architecture processor. The LS2080AQDS provides validation and > >>>> -SW development platform for the Freescale LS2080A processor series, with > >>>> -a complete debugging environment. > >>>> +The LS2085A Reference Design (RDB) is a high-performance computing, > >>>> +evaluation, and development platform that supports the QorIQ LS2085A > >>>> +Layerscape Architecture processor. > >>> > >>> "LayerScape" and 2080 should be fixed in the QDS patch as well. > >>> > >>>> @@ -113,25 +105,25 @@ unsigned long get_board_ddr_clk(void); > >>>> #define CONFIG_SYS_NAND_CSOR (CSOR_NAND_ECC_ENC_EN /* ECC on encode */ \ > >>>> | CSOR_NAND_ECC_DEC_EN /* ECC on decode */ \ > >>>> | CSOR_NAND_ECC_MODE_4 /* 4-bit ECC */ \ > >>>> - | CSOR_NAND_RAL_3 /* RAL = 2Byes */ \ > >>>> - | CSOR_NAND_PGS_2K /* Page Size = 2K */ \ > >>>> - | CSOR_NAND_SPRZ_64/* Spare size = 64 */ \ > >>>> - | CSOR_NAND_PB(64)) /*Pages Per Block = 64*/ > >>>> + | CSOR_NAND_RAL_3 /* RAL = 3Byes */ \ > >>>> + | CSOR_NAND_PGS_4K /* Page Size = 4K */ \ > >>>> + | CSOR_NAND_SPRZ_224 /* Spare size = 224 */ \ > >>>> + | CSOR_NAND_PB(128)) /*Pages Per Block = 128*/ > >>> > >>> From this it looks like the QDS patch still has a comment/code > >>> inconsistency with RAL. > >>> > >> > >> Let me re-generate the patch using patman, without -C --find-copies-harder flag > >> so they don't show as copy-n-modify. > > > > Why? I found it rather useful. In any case, the error in the QDS file > > will still be there. > > > > I have to modify patman to have these flags. Personally I prefer to use them. I don't understand what this has to do with my original comment. > But I guess if everyone uses the patman, so should I. I don't think it's mandatory. :-) Assuming you're getting some benefit from patman, you could add support for those flags. They're useful. -Scott