From: "Jaggi, Manish" <Manish.Jaggi@caviumnetworks.com>
Subject: Re: [PATCH v1 2/3] xen/arm: smmu: Renaming
 arm_smmu_xen_domain with, domain_iommu_info
Date: Fri, 27 Mar 2015 13:24:13 +0000
Message-ID: <1427462671468.35060@caviumnetworks.com>
References: <55150552.8060402@caviumnetworks.com>,
	<551554C9.9090601@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
In-Reply-To: <551554C9.9090601@linaro.org>
Content-Language: en-US
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>, Xen Devel <xen-devel@lists.xen.org>, "Prasun.kapoor@cavium.com" <Prasun.kapoor@cavium.com>, "Kumar, Vijaya" <Vijaya.Kumar@caviumnetworks.com>, Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>


Regards,
Manish Jaggi

________________________________________
From: Julien Grall <julien.grall@linaro.org>
Sent: Friday, March 27, 2015 6:32 PM
To: Jaggi, Manish; Xen Devel; Prasun.kapoor@cavium.com; Kumar, Vijaya; Ian Campbell; Stefano Stabellini
Subject: Re: [PATCH v1 2/3] xen/arm: smmu: Renaming arm_smmu_xen_domain with, domain_iommu_info

Hi Manish,

On 27/03/15 07:22, Manish Jaggi wrote:
> The name arm_smmu_xen_domain was mapped to domain_hvm_iommu(d)->arch.priv.
> Also there are a lot of datastructre in smmu.c with name ending in domain

data structure.

> it is not intuitive and code is hard to understand.

Now it's more difficult to differentiate domain_iommu_info and iommu_domain.

[manish] Please see my previous mail. Also please pick any other name there are so many data structures which end up in domain. What is the difference between arm_smmu_domain and arm_smmu_xen_domain, I cannot find it based on name. 

Regards,

Regards,

--
Julien Grall