From: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Date: Fri, 27 Mar 2015 15:46:26 +0000
Subject: [U-Boot] [PATCH 1/2] mpc85xx gpio related header files changes
 to compile common cmd_gpio.c
In-Reply-To: <55156E74.7080405@arcturusnetworks.com>
References: <55147741.80406@arcturusnetworks.com>
 <1427415986.13051.48.camel@transmode.se>
 <55156E74.7080405@arcturusnetworks.com>
Message-ID: <1427471186.13051.66.camel@transmode.se>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, 2015-03-27 at 10:51 -0400, Oleksandr G Zhadan wrote:
> Extra gpio bank argument at low level may be discussable, but IMPO we 
> should not brake standard int gpio_set_value(unsigned gpio, int value) 
> definition.
> 
> And the reason of this patch is to fix:
> 
> 1. Incompatibility in functions gpio_free() and gpio_set_value() 
> definitions between <asm/gpio.h> and <asm-generic/gpio.h> (void vs int)
> 
> 2. Compilation error when build common/cmd_gpio.c for mpc85xx (p1020)

Sure, when I saw "mpc85xx gpio .." I remembered seeing this flaw so I figured
I point it out before I forget again.

This also makes me remember, drivers/spi/fsl_espi.c is broken for anything
but reading an EEPROM.

  Jocke