Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mail.openembedded.org (Postfix) with ESMTP id 161EA73BFF for ; Fri, 27 Mar 2015 17:14:01 +0000 (UTC) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 27 Mar 2015 10:14:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,479,1422950400"; d="scan'208";a="686656447" Received: from bottazzini-thinkpad-t430.bz.intel.com (HELO [10.218.99.143]) ([10.218.99.143]) by fmsmga001.fm.intel.com with ESMTP; 27 Mar 2015 10:14:03 -0700 Message-ID: <1427476419.2868.5.camel@bottazzini-ThinkPad-T430> From: "Bottazzini, Bruno" To: Otavio Salvador Date: Fri, 27 Mar 2015 14:13:39 -0300 In-Reply-To: References: <1427320163-9262-1-git-send-email-bruno.bottazzini@intel.com> <1427320163-9262-4-git-send-email-bruno.bottazzini@intel.com> <20150326082923.GA7370@ad.chargestorm.se> <1427377220.2918.8.camel@bottazzini-ThinkPad-T430> <20150327145747.GE21905@ad.chargestorm.se> <1427476146.2868.3.camel@bottazzini-ThinkPad-T430> X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Cc: Anders Darander , Patches and discussions about the oe-core layer Subject: Re: [PATCH 3/4] systemd: split modules into packages X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2015 17:14:04 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Sex, 2015-03-27 at 14:11 -0300, Otavio Salvador wrote: > On Fri, Mar 27, 2015 at 2:09 PM, Bottazzini, Bruno > wrote: > > On Sex, 2015-03-27 at 15:57 +0100, Anders Darander wrote: > >> * Bottazzini, Bruno [150326 14:40]: > >> > >> > On Qui, 2015-03-26 at 08:56 -0300, Otavio Salvador wrote: > >> > > On Thu, Mar 26, 2015 at 5:29 AM, Anders Darander wrote: > >> > > > * Bruno Bottazzini [150325 22:50]: > >> > >> > > >> if one wants to launch a simple deamon, most modules are not > >> > > >> required. > >> > > >> He will be able to save space and exclude unwanted packages > >> > > >> from the final image. > >> > >> > > > I like this, though I've got a few questions that I just noticed. > >> > >> > > >> -PACKAGECONFIG ??= "xz ldconfig \ > >> > > >> +PACKAGECONFIG ??= " \ > >> > > >> + gcrypt \ > >> > > >> + kmod \ > >> > > >> + ldconfig \ > >> > > >> + ${@bb.utils.contains('DISTRO_FEATURES', 'blkid', 'blkid', '', d)} \ > >> > > >> + ${@bb.utils.contains('DISTRO_FEATURES', 'efi', 'efi', '', d)} \ > >> > > >> + ${@bb.utils.contains('DISTRO_FEATURES', 'lz4', 'lz4', '', d)} \ > >> > > >> + ${@bb.utils.contains('DISTRO_FEATURES', 'xz', 'xz', '', d)} \ > >> > > >> + ${@bb.utils.contains('DISTRO_FEATURES', 'libidn', 'libidn', '', d)} \ > >> > > >> + ${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)} \ > >> > > >> ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam', '', d)} \ > >> > > >> ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)}" > >> > >> > > > It might be worth noting that xz has gone from being explicitly enabled, > >> > > > to depend on a DISTRO_FEATURES. > >> > >> > > Agreed and we shouldn't explode the number of possible dsitro > >> > > features. I'd also prefer if xz were kept enable by default so we > >> > > don't make a behavior change under the hood. > >> > >> > > ... > >> > > >> PACKAGECONFIG[resolved] = "--enable-resolved,--disable-resolved" > >> > > >> -PACKAGECONFIG[networkd] = "--enable-networkd,--disable-networkd" > >> > >> > > > Why do you remove networkd as a PACKAGECONFIG? > >> > >> > > If there is a real reason for this, it must be recorded in commit log as well. > >> > >> > Guys, if you continue this patch you will see that networkd will always > >> > be enabled. Systemd will always configure/make it however, the package > >> > will not be installed if the user wants to. > >> > >> > With PACKAGECONFIG, we may not get everything "for free" as some data > >> > files will be installed regardless as well as some components from > >> > systemd cannot be disabled by their build system but we can run without > >> > them, for instance we can run without journald. > >> > >> The advantage of also keeping the PACKAGECONFIG for e.g. networkd (and > >> as much other things as possible) is that we're also reducing the build > >> time and size. Sure, it might not be by much, but all small bits are > >> valuable. > >> > > > > You are right! Maybe we should mix them ? > > > > e.g. if PACKAGECONFIG networkd is disabled then the package > > systemd-services-networkd will not be included. > > > > What do you think? > > You can add the files conditionally so these empty packages won't be generated. Indeed, do you know how to do this condition or have you got any example? >