From: "Jaggi, Manish" <Manish.Jaggi@caviumnetworks.com>
Subject: Re: [PATCH v1 2/3] xen/arm: smmu: Renaming
 arm_smmu_xen_domain with, domain_iommu_info
Date: Fri, 27 Mar 2015 17:58:44 +0000
Message-ID: <1427479143491.30556@caviumnetworks.com>
References: <55150552.8060402@caviumnetworks.com>,
	<551554C9.9090601@linaro.org>
	<1427462671468.35060@caviumnetworks.com>, <55155CF8.7060804@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55155CF8.7060804@linaro.org>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>, Xen Devel <xen-devel@lists.xen.org>, "Prasun.kapoor@cavium.com" <Prasun.kapoor@cavium.com>, "Kumar, Vijaya" <Vijaya.Kumar@caviumnetworks.com>, Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org



Regards,
Manish Jaggi

________________________________________
From: Julien Grall <julien.grall@linaro.org>
Sent: Friday, March 27, 2015 7:06 PM
To: Jaggi, Manish; Xen Devel; Prasun.kapoor@cavium.com; Kumar, Vijaya; Ian Campbell; Stefano Stabellini
Subject: Re: [PATCH v1 2/3] xen/arm: smmu: Renaming arm_smmu_xen_domain with, domain_iommu_info

On 27/03/15 13:24, Jaggi, Manish wrote:
> Now it's more difficult to differentiate domain_iommu_info and iommu_domain.
>
> [manish] Please see my previous mail. Also please pick any other name there are so many data structures which end up in domain. What is the difference between arm_smmu_domain and arm_smmu_xen_domain, I cannot find it based on name.

Again, did you read the common above the structure?
[manish] yes but naming is a bit confusing and need to be fixed

How do you different domain_iommu_info vs iommu_domain?
[manish] ok lets change it to domain_iommu_priv. here domain refers to a xen VM domain. While iommu_domain refers to a iommu domain within a particular smmu.

Regards,


--
Julien Grall