From: =?UTF-8?q?Michal=20Mal=C3=BD?= Subject: [PATCH v2 07/15] HID: hid-lg: Check return values from lg[N]ff_init() Date: Wed, 8 Apr 2015 22:56:45 +0200 Message-ID: <1428526613-24239-8-git-send-email-madcatxster@devoid-pointer.net> References: <1428526613-24239-1-git-send-email-madcatxster@devoid-pointer.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from imap.devoid-pointer.net ([31.31.77.140]:33011 "EHLO smtp.devoid-pointer.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754720AbbDHU52 (ORCPT ); Wed, 8 Apr 2015 16:57:28 -0400 In-Reply-To: <1428526613-24239-1-git-send-email-madcatxster@devoid-pointer.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: jkosina@suse.cz Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.or, elias.vds@gmail.com, simon@mungewell.org, =?UTF-8?q?Michal=20Mal=C3=BD?= Check return values from lg[N]ff_init(). hid-lg did not check return va= lues from the lg[N]_init() functions, possibly trying to work with a device whose initialization has failed. Signed-off-by: Michal Mal=C3=BD --- drivers/hid/hid-lg.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-lg.c b/drivers/hid/hid-lg.c index b86c18e..c797781 100644 --- a/drivers/hid/hid-lg.c +++ b/drivers/hid/hid-lg.c @@ -712,13 +712,16 @@ static int lg_probe(struct hid_device *hdev, cons= t struct hid_device_id *id) } =20 if (drv_data->quirks & LG_FF) - lgff_init(hdev); + ret =3D lgff_init(hdev); if (drv_data->quirks & LG_FF2) - lg2ff_init(hdev); + ret =3D lg2ff_init(hdev); if (drv_data->quirks & LG_FF3) - lg3ff_init(hdev); + ret =3D lg3ff_init(hdev); if (drv_data->quirks & LG_FF4) - lg4ff_init(hdev); + ret =3D lg4ff_init(hdev); + + if (ret) + goto err_free; =20 return 0; err_free: --=20 2.3.5 -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html