From: James Bottomley Subject: Re: [scsi:misc 14/106] drivers/scsi/storvsc_drv.c:1658 storvsc_queuecommand() warn: curly braces intended? Date: Mon, 13 Apr 2015 14:26:12 +0000 Message-ID: <1428935248.2314.3.camel@Odin.com> References: <20150413115603.GR16501@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx2.parallels.com ([199.115.105.18]:37503 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751604AbbDMO1b (ORCPT ); Mon, 13 Apr 2015 10:27:31 -0400 In-Reply-To: <20150413115603.GR16501@mwanda> Content-Language: en-US Content-ID: <2ADDA923A9F04044957167D30B2A5849@sw.swsoft.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "dan.carpenter@oracle.com" Cc: "linux-scsi@vger.kernel.org" , "kbuild@01.org" , "kys@microsoft.com" T24gTW9uLCAyMDE1LTA0LTEzIGF0IDE0OjU2ICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K PiB0cmVlOiAgIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9q ZWpiL3Njc2kuZ2l0IG1pc2MNCj4gaGVhZDogICAwMzUxYjhmODEzOTJjNmRiYmJiMDM2ZTVjOGY3 M2NlZmY2ODcyNmU5DQo+IGNvbW1pdDogYmUwY2Y2Y2EzMDFjNjE0NThkYzRhYTFhMzdhY2Y0ZjU4 ZDJlZDNkNiBbMTQvMTA2XSBzY3NpOiBzdG9ydnNjOiBTZXQgdGhlIHRhYmxlc2l6ZSBiYXNlZCBv biB0aGUgaW5mb3JtYXRpb24gZ2l2ZW4gYnkgdGhlIGhvc3QNCj4gDQo+IGRyaXZlcnMvc2NzaS9z dG9ydnNjX2Rydi5jOjE2NTggc3RvcnZzY19xdWV1ZWNvbW1hbmQoKSB3YXJuOiBjdXJseSBicmFj ZXMgaW50ZW5kZWQ/DQo+IA0KPiBnaXQgcmVtb3RlIGFkZCBzY3NpIGdpdDovL2dpdC5rZXJuZWwu b3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9qZWpiL3Njc2kuZ2l0DQo+IGdpdCByZW1vdGUg dXBkYXRlIHNjc2kNCj4gZ2l0IGNoZWNrb3V0IGJlMGNmNmNhMzAxYzYxNDU4ZGM0YWExYTM3YWNm NGY1OGQyZWQzZDYNCj4gdmltICsxNjU4IGRyaXZlcnMvc2NzaS9zdG9ydnNjX2Rydi5jDQo+IA0K PiBjNWI0NjNhZSBkcml2ZXJzL3N0YWdpbmcvaHYvc3RvcnZzY19kcnYuYyBLLiBZLiBTcmluaXZh c2FuIDIwMTEtMDUtMTAgIDE2NDIgIAkJCXNnbCA9IGNtZF9yZXF1ZXN0LT5ib3VuY2Vfc2dsOw0K PiBjNWI0NjNhZSBkcml2ZXJzL3N0YWdpbmcvaHYvc3RvcnZzY19kcnYuYyBLLiBZLiBTcmluaXZh c2FuIDIwMTEtMDUtMTAgIDE2NDMgIAkJCXNnX2NvdW50ID0gY21kX3JlcXVlc3QtPmJvdW5jZV9z Z2xfY291bnQ7DQo+IGM1YjQ2M2FlIGRyaXZlcnMvc3RhZ2luZy9odi9zdG9ydnNjX2Rydi5jIEsu IFkuIFNyaW5pdmFzYW4gMjAxMS0wNS0xMCAgMTY0NCAgCQl9DQo+IGM1YjQ2M2FlIGRyaXZlcnMv c3RhZ2luZy9odi9zdG9ydnNjX2Rydi5jIEsuIFkuIFNyaW5pdmFzYW4gMjAxMS0wNS0xMCAgMTY0 NSAgDQo+IGJlMGNmNmNhIGRyaXZlcnMvc2NzaS9zdG9ydnNjX2Rydi5jICAgICAgIEsuIFkuIFNy aW5pdmFzYW4gMjAxNS0wMy0yNyAgMTY0NiAgDQo+IGJlMGNmNmNhIGRyaXZlcnMvc2NzaS9zdG9y dnNjX2Rydi5jICAgICAgIEsuIFkuIFNyaW5pdmFzYW4gMjAxNS0wMy0yNyAgMTY0NyAgCQlpZiAo c2dfY291bnQgPiBNQVhfUEFHRV9CVUZGRVJfQ09VTlQpIHsNCj4gYmUwY2Y2Y2EgZHJpdmVycy9z Y3NpL3N0b3J2c2NfZHJ2LmMgICAgICAgSy4gWS4gU3Jpbml2YXNhbiAyMDE1LTAzLTI3ICAxNjQ4 ICANCj4gYmUwY2Y2Y2EgZHJpdmVycy9zY3NpL3N0b3J2c2NfZHJ2LmMgICAgICAgSy4gWS4gU3Jp bml2YXNhbiAyMDE1LTAzLTI3ICAxNjQ5ICAJCQlwYXlsb2FkX3N6ID0gKHNnX2NvdW50ICogc2l6 ZW9mKHZvaWQgKikgKw0KPiBiZTBjZjZjYSBkcml2ZXJzL3Njc2kvc3RvcnZzY19kcnYuYyAgICAg ICBLLiBZLiBTcmluaXZhc2FuIDIwMTUtMDMtMjcgIDE2NTAgIAkJCQkgICAgICBzaXplb2Yoc3Ry dWN0IHZtYnVzX3BhY2tldF9tcGJfYXJyYXkpKTsNCj4gYmUwY2Y2Y2EgZHJpdmVycy9zY3NpL3N0 b3J2c2NfZHJ2LmMgICAgICAgSy4gWS4gU3Jpbml2YXNhbiAyMDE1LTAzLTI3ICAxNjUxICAJCQlw YXlsb2FkID0ga21hbGxvYyhwYXlsb2FkX3N6LCBHRlBfQVRPTUlDKTsNCj4gYmUwY2Y2Y2EgZHJp dmVycy9zY3NpL3N0b3J2c2NfZHJ2LmMgICAgICAgSy4gWS4gU3Jpbml2YXNhbiAyMDE1LTAzLTI3 ICAxNjUyICAJCQlpZiAoIXBheWxvYWQpIHsNCj4gYmUwY2Y2Y2EgZHJpdmVycy9zY3NpL3N0b3J2 c2NfZHJ2LmMgICAgICAgSy4gWS4gU3Jpbml2YXNhbiAyMDE1LTAzLTI3ICAxNjUzICAJCQkJaWYg KGNtZF9yZXF1ZXN0LT5ib3VuY2Vfc2dsX2NvdW50KQ0KPiANCj4gU3RhcnQgYmxvY2sgaGVyZS4N Cj4gDQo+IGJlMGNmNmNhIGRyaXZlcnMvc2NzaS9zdG9ydnNjX2Rydi5jICAgICAgIEsuIFkuIFNy aW5pdmFzYW4gMjAxNS0wMy0yNyAgMTY1NCAgCQkJCQlkZXN0cm95X2JvdW5jZV9idWZmZXIoDQo+ IGJlMGNmNmNhIGRyaXZlcnMvc2NzaS9zdG9ydnNjX2Rydi5jICAgICAgIEsuIFkuIFNyaW5pdmFz YW4gMjAxNS0wMy0yNyAgMTY1NSAgCQkJCQljbWRfcmVxdWVzdC0+Ym91bmNlX3NnbCwNCj4gYmUw Y2Y2Y2EgZHJpdmVycy9zY3NpL3N0b3J2c2NfZHJ2LmMgICAgICAgSy4gWS4gU3Jpbml2YXNhbiAy MDE1LTAzLTI3ICAxNjU2ICAJCQkJCWNtZF9yZXF1ZXN0LT5ib3VuY2Vfc2dsX2NvdW50KTsNCj4g YmUwY2Y2Y2EgZHJpdmVycy9zY3NpL3N0b3J2c2NfZHJ2LmMgICAgICAgSy4gWS4gU3Jpbml2YXNh biAyMDE1LTAzLTI3ICAxNjU3ICANCj4gYmUwY2Y2Y2EgZHJpdmVycy9zY3NpL3N0b3J2c2NfZHJ2 LmMgICAgICAgSy4gWS4gU3Jpbml2YXNhbiAyMDE1LTAzLTI3IEAxNjU4ICAJCQkJCXJldHVybiBT Q1NJX01MUVVFVUVfREVWSUNFX0JVU1k7DQo+IA0KPiBFbmQgYmxvY2sgaGVyZS4NCj4gDQo+IGJl MGNmNmNhIGRyaXZlcnMvc2NzaS9zdG9ydnNjX2Rydi5jICAgICAgIEsuIFkuIFNyaW5pdmFzYW4g MjAxNS0wMy0yNyAgMTY1OSAgCQkJfQ0KPiBiZTBjZjZjYSBkcml2ZXJzL3Njc2kvc3RvcnZzY19k cnYuYyAgICAgICBLLiBZLiBTcmluaXZhc2FuIDIwMTUtMDMtMjcgIDE2NjAgIAkJfQ0KPiBiZTBj ZjZjYSBkcml2ZXJzL3Njc2kvc3RvcnZzY19kcnYuYyAgICAgICBLLiBZLiBTcmluaXZhc2FuIDIw MTUtMDMtMjcgIDE2NjEgIA0KPiBiZTBjZjZjYSBkcml2ZXJzL3Njc2kvc3RvcnZzY19kcnYuYyAg ICAgICBLLiBZLiBTcmluaXZhc2FuIDIwMTUtMDMtMjcgIDE2NjIgIAkJcGF5bG9hZC0+cmFuZ2Uu bGVuID0gbGVuZ3RoOw0KPiBiZTBjZjZjYSBkcml2ZXJzL3Njc2kvc3RvcnZzY19kcnYuYyAgICAg ICBLLiBZLiBTcmluaXZhc2FuIDIwMTUtMDMtMjcgIDE2NjMgIAkJcGF5bG9hZC0+cmFuZ2Uub2Zm c2V0ID0gc2dsWzBdLm9mZnNldDsNCj4gYmUwY2Y2Y2EgZHJpdmVycy9zY3NpL3N0b3J2c2NfZHJ2 LmMgICAgICAgSy4gWS4gU3Jpbml2YXNhbiAyMDE1LTAzLTI3ICAxNjY0ICANCj4gYWFjZWQ5OTMg ZHJpdmVycy9zY3NpL3N0b3J2c2NfZHJ2LmMgICAgICAgSy4gWS4gU3Jpbml2YXNhbiAyMDE1LTAz LTI3ICAxNjY1ICAJCWN1cl9zZ2wgPSBzZ2w7DQo+IGFhY2VkOTkzIGRyaXZlcnMvc2NzaS9zdG9y dnNjX2Rydi5jICAgICAgIEsuIFkuIFNyaW5pdmFzYW4gMjAxNS0wMy0yNyAgMTY2NiAgCQlmb3Ig KGkgPSAwOyBpIDwgc2dfY291bnQ7IGkrKykgew0KDQpJIHRoaW5rIHRoaXMgaXMganVzdCBzY3Jl d2VkIHVwIGluZGVudGF0aW9uLiAgWW91IGhhdmUgdG8gcmV0dXJuDQpERVZJQ0VfQlVTWSBmb3Ig dGhlIGttYWxsb2MgZmFpbHVyZS4gIFRoZSBpZiBpcyBqdXN0IHNlZWluZyBpZiBjbGVhbnVwDQpp cyBuZWVkZWQuDQoNCkphbWVzDQoNCg==