Received: from eggs.gnu.org ([2001:4830:134:3::10]:44170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhwOO-0007Ce-0D for qemu-devel@nongnu.org; Tue, 14 Apr 2015 04:40:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhwOJ-0005yP-7V for qemu-devel@nongnu.org; Tue, 14 Apr 2015 04:40:23 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:38206 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhwOI-0005xB-SU for qemu-devel@nongnu.org; Tue, 14 Apr 2015 04:40:19 -0400 From: Peter Lieven Date: Tue, 14 Apr 2015 10:37:11 +0200 Message-Id: <1429000631-649-1-git-send-email-pl@kamp.de> Subject: [Qemu-devel] [PATCH] block/iscsi: do not forget to logout from target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, Peter Lieven , ronniesahlberg@gmail.com, qemu-block@nongnu.org, qemu-stable@nongnu.org We actually were always impolitely dropping the connection and not cleanly logging out. Cc: qemu-stable@nongnu.org Signed-off-by: Peter Lieven --- block/iscsi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index ab20e4d..0b6d3dd 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1503,6 +1503,9 @@ out: if (ret) { if (iscsi != NULL) { + if (iscsi_is_logged_in(iscsi)) { + iscsi_logout_sync(iscsi); + } iscsi_destroy_context(iscsi); } memset(iscsilun, 0, sizeof(IscsiLun)); @@ -1516,6 +1519,9 @@ static void iscsi_close(BlockDriverState *bs) struct iscsi_context *iscsi = iscsilun->iscsi; iscsi_detach_aio_context(bs); + if (iscsi_is_logged_in(iscsi)) { + iscsi_logout_sync(iscsi); + } iscsi_destroy_context(iscsi); g_free(iscsilun->zeroblock); g_free(iscsilun->allocationmap); -- 1.9.1