From: Tvrtko Ursulin Subject: [PATCH i-g-t] igt_kms: Avoid NULL ptr deref when commiting disabled planes Date: Tue, 28 Apr 2015 11:57:47 +0100 Message-ID: <1430218667-2747-1-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 472FD6E05D for ; Tue, 28 Apr 2015 03:57:50 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org RnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KCkkgdGhpbms7 CgogICBjb21taXQgYTI2ZjlmOWFkMGU2NzljN2NlNDEzYTI1ZDM0ZjY5MTRlMTE3NDE1MQogICBB dXRob3I6IGNoYW5kcmEga29uZHVydSA8Y2hhbmRyYS5rb25kdXJ1QGludGVsLmNvbT4KICAgRGF0 ZTogICBNb24gTWFyIDMwIDEzOjUyOjA0IDIwMTUgLTA3MDAKCiAgICAgICBpLWctdDogQWRkaW5n IHBsYW5lIHNjYWxpbmcgdGVzdCBjYXNlCgppbnRyb2R1Y2VkIGEgY29uZGl0aW9uIHdoZXJlIGl0 IGF0dGVtcHRzIHRvIHVwZGF0ZSBhIGRpc2FibGVkIHBsYW5lIGJlY2F1c2UKb2YgdGhlIG5ld2x5 IGludHJvZHVjZWQgc2l6ZV9jaGFuZ2VkIGZsYWcgd2hpY2ggaXMgc2V0IGZvciBkaXNhYmxlZCBm cmFtZQpidWZmZXJzLiBSZXN1bHQgaXMgYSBOVUxMIHB0ciBkZXJlZiBpbiBpZ3RfZHJtX3BsYW5l X2NvbW1pdCAocGxhbmUtPmZiLT5zcmNfeCkuCgpTdGFydCByZWNvZ25pc2luZyB0aGlzIGNhc2Ug YXMgZGlzYWJsZWQgcGxhbmUgYW5kIGFjdCBhY2NvcmRpbmdseS4KCkFsc28gY2xlYW51cCB0aGUg Y29kZSBpbiBpZ3RfcGxhbmVfc2V0X2ZiIGEgYml0LgoKU2lnbmVkLW9mZi1ieTogVHZydGtvIFVy c3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KQ2M6IGNoYW5kcmEga29uZHVydSA8Y2hh bmRyYS5rb25kdXJ1QGludGVsLmNvbT4KLS0tClRoZXJlIG1pZ2h0IGJlIGEgYmV0dGVyIGZpeCwg YnV0IHRoaXMgd29ya3MgZm9yIG1lLgotLS0KIGxpYi9pZ3Rfa21zLmMgfCAxMyArKysrLS0tLS0t LS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL2xpYi9pZ3Rfa21zLmMgYi9saWIvaWd0X2ttcy5jCmluZGV4IGI3ZDFlOTAuLmI1 YmEyNzMgMTAwNjQ0Ci0tLSBhL2xpYi9pZ3Rfa21zLmMKKysrIGIvbGliL2lndF9rbXMuYwpAQCAt MTMzMSw3ICsxMzMxLDcgQEAgc3RhdGljIGludCBpZ3RfZHJtX3BsYW5lX2NvbW1pdChpZ3RfcGxh bmVfdCAqcGxhbmUsCiAJZmJfaWQgPSBpZ3RfcGxhbmVfZ2V0X2ZiX2lkKHBsYW5lKTsKIAljcnRj X2lkID0gb3V0cHV0LT5jb25maWcuY3J0Yy0+Y3J0Y19pZDsKIAotCWlmIChwbGFuZS0+ZmJfY2hh bmdlZCAmJiBmYl9pZCA9PSAwKSB7CisJaWYgKChwbGFuZS0+ZmJfY2hhbmdlZCB8fCBwbGFuZS0+ c2l6ZV9jaGFuZ2VkKSAmJiBmYl9pZCA9PSAwKSB7CiAJCUxPRyhkaXNwbGF5LAogCQkgICAgIiVz OiBTZXRQbGFuZSBwaXBlICVzLCBwbGFuZSAlZCwgZGlzYWJsaW5nXG4iLAogCQkgICAgaWd0X291 dHB1dF9uYW1lKG91dHB1dCksCkBAIC0xNzY1LDE0ICsxNzY1LDYgQEAgdm9pZCBpZ3RfcGxhbmVf c2V0X2ZiKGlndF9wbGFuZV90ICpwbGFuZSwgc3RydWN0IGlndF9mYiAqZmIpCiAJcGxhbmUtPmZi ID0gZmI7CiAJLyogaGFjayB0byBrZWVwIHRlc3RzIHdvcmtpbmcgdGhhdCBkb24ndCBjYWxsIGln dF9wbGFuZV9zZXRfc2l6ZSgpICovCiAJaWYgKGZiKSB7Ci0JCXBsYW5lLT5jcnRjX3cgPSBmYi0+ d2lkdGg7Ci0JCXBsYW5lLT5jcnRjX2ggPSBmYi0+aGVpZ2h0OwotCX0gZWxzZSB7Ci0JCXBsYW5l LT5jcnRjX3cgPSAwOwotCQlwbGFuZS0+Y3J0Y19oID0gMDsKLQl9Ci0KLQlpZiAoZmIpIHsKIAkJ Lyogc2V0IGRlZmF1bHQgcGxhbmUgcG9zL3NpemUgYXMgZmIgc2l6ZSAqLwogCQlwbGFuZS0+Y3J0 Y194ID0gMDsKIAkJcGxhbmUtPmNydGNfeSA9IDA7CkBAIC0xNzg0LDYgKzE3NzYsOSBAQCB2b2lk IGlndF9wbGFuZV9zZXRfZmIoaWd0X3BsYW5lX3QgKnBsYW5lLCBzdHJ1Y3QgaWd0X2ZiICpmYikK IAkJZmItPnNyY195ID0gMDsKIAkJZmItPnNyY193ID0gZmItPndpZHRoOwogCQlmYi0+c3JjX2gg PSBmYi0+aGVpZ2h0OworCX0gZWxzZSB7CisJCXBsYW5lLT5jcnRjX3cgPSAwOworCQlwbGFuZS0+ Y3J0Y19oID0gMDsKIAl9CiAKIAlwbGFuZS0+ZmJfY2hhbmdlZCA9IHRydWU7Ci0tIAoyLjMuNQoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK