From: Ian Campbell <ijc@hellion.org.uk>
Date: Sat, 02 May 2015 15:03:30 +0100
Subject: [U-Boot] [PATCH 8/8] sunxi: ehci: Convert to the driver-model
In-Reply-To: <1430404524-31413-9-git-send-email-hdegoede@redhat.com>
References: <1430404524-31413-1-git-send-email-hdegoede@redhat.com>
 <1430404524-31413-9-git-send-email-hdegoede@redhat.com>
Message-ID: <1430575410.15640.123.camel@hellion.org.uk>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thu, 2015-04-30 at 16:35 +0200, Hans de Goede wrote:
> +	if (hccr == (void *)SUNXI_USB1_BASE) {
> +		priv->ahb_gate_mask = 1 << AHB_GATE_OFFSET_USB_EHCI0;
> +		priv->phy_index = 1;

Inferring these from the base address is a bit unfortunate, should we
not get told this by the DT, or from something higher up?

I have a feeling the answer will be "this can go away when X, Y & X have
happened", in which case perhaps a comment to that affect?

BTW I ignored patches 1..7 based on the diffstats, please let me know if
I should take a look for some reason.

Ian.