Received: from eggs.gnu.org ([2001:4830:134:3::10]:44794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuSo9-0002mh-MO for qemu-devel@nongnu.org; Mon, 18 May 2015 17:42:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuSo6-0008QO-Fj for qemu-devel@nongnu.org; Mon, 18 May 2015 17:42:45 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:101::1]:33735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuSo6-0008Q7-9o for qemu-devel@nongnu.org; Mon, 18 May 2015 17:42:42 -0400 From: Aurelien Jarno Date: Mon, 18 May 2015 23:42:26 +0200 Message-Id: <1431985349-11226-3-git-send-email-aurelien@aurel32.net> In-Reply-To: <1431985349-11226-1-git-send-email-aurelien@aurel32.net> References: <1431985349-11226-1-git-send-email-aurelien@aurel32.net> Subject: [Qemu-devel] [PATCH 2/5] target-s390x: simplify SCKC helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alexander Graf , Aurelien Jarno , Richard Henderson The clock comparator and the QEMU timer work the same way, triggering at a given time, they just differ by the origin and the scale. It is therefore possible to go from one to another without using the current clock value. This spares two calls to qemu_clock_get_ns, which probably return slightly different values, possibly reducing the accuracy. Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- target-s390x/misc_helper.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target-s390x/misc_helper.c b/target-s390x/misc_helper.c index 230bafd..120807f 100644 --- a/target-s390x/misc_helper.c +++ b/target-s390x/misc_helper.c @@ -291,12 +291,13 @@ void HELPER(sckc)(CPUS390XState *env, uint64_t time) return; } - /* difference between now and then */ - time -= clock_value(env); + /* difference between origins */ + time -= env->tod_offset; + /* nanoseconds */ time = tod2time(time); - timer_mod(env->tod_timer, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + time); + timer_mod(env->tod_timer, env->tod_basetime + time); } /* Store Clock Comparator */ -- 2.1.4