From: Bin Meng Date: Thu, 27 Aug 2015 22:25:54 -0700 Subject: [U-Boot] [PATCH v3 4/9] dm: eth: Correctly detect alias in eth_get_dev_by_name() In-Reply-To: <1440739559-16225-1-git-send-email-bmeng.cn@gmail.com> References: <1440739559-16225-1-git-send-email-bmeng.cn@gmail.com> Message-ID: <1440739559-16225-4-git-send-email-bmeng.cn@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de When given a device name string, we should test to see if it is really an alias like "eth#". Signed-off-by: Bin Meng Acked-by: Joe Hershberger --- Changes in v3: None Changes in v2: - Change to use strncmp() net/eth.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/eth.c b/net/eth.c index c46a8c3..26520d3 100644 --- a/net/eth.c +++ b/net/eth.c @@ -195,10 +195,11 @@ struct udevice *eth_get_dev_by_name(const char *devname) const char *startp = NULL; struct udevice *it; struct uclass *uc; + int len = strlen("eth"); /* Must be longer than 3 to be an alias */ - if (strlen(devname) > strlen("eth")) { - startp = devname + strlen("eth"); + if (!strncmp(devname, "eth", len) && strlen(devname) > len) { + startp = devname + len; seq = simple_strtoul(startp, &endp, 10); } -- 1.8.2.1