Received: from eggs.gnu.org ([2001:4830:134:3::10]:57087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXCIA-0005Me-HV for qemu-devel@nongnu.org; Wed, 02 Sep 2015 13:57:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXCI9-0003d2-Lp for qemu-devel@nongnu.org; Wed, 02 Sep 2015 13:57:50 -0400 Received: from mail-pa0-x22e.google.com ([2607:f8b0:400e:c03::22e]:34328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXCI9-0003ct-Gr for qemu-devel@nongnu.org; Wed, 02 Sep 2015 13:57:49 -0400 Received: by padhy1 with SMTP id hy1so18734138pad.1 for ; Wed, 02 Sep 2015 10:57:49 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Wed, 2 Sep 2015 10:57:38 -0700 Message-Id: <1441216660-8717-10-git-send-email-rth@twiddle.net> In-Reply-To: <1441216660-8717-1-git-send-email-rth@twiddle.net> References: <1441216660-8717-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH v2 09/11] target-arm: Eliminate unnecessary zero-extend in disas_bitfield List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org For !SF, this initial ext32u can't be optimized away by the current TCG code generator. (It would require backward bit liveness propagation.) But since the range of bits for !SF are already constrained by unallocated_encoding, we'll never reference the high bits anyway. Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 8c94edf..10f8825 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -2997,7 +2997,11 @@ static void disas_bitfield(DisasContext *s, uint32_t insn) } tcg_rd = cpu_reg(s, rd); - tcg_tmp = read_cpu_reg(s, rn, sf); + + /* Suppress the zero-extend for !sf. Since RI and SI are constrained + to be smaller than bitsize, we'll never reference data outside the + low 32-bits anyway. */ + tcg_tmp = read_cpu_reg(s, rn, 1); /* Recognize the common aliases. */ if (opc == 0) { /* SBFM */ -- 2.4.3