Received: from eggs.gnu.org ([2001:4830:134:3::10]:52968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za6RB-0000Ue-5Q for qemu-devel@nongnu.org; Thu, 10 Sep 2015 14:19:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Za6R8-0001pE-1I for qemu-devel@nongnu.org; Thu, 10 Sep 2015 14:19:09 -0400 Received: from mail-qg0-x22b.google.com ([2607:f8b0:400d:c04::22b]:33778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za6R7-0001p6-RP for qemu-devel@nongnu.org; Thu, 10 Sep 2015 14:19:05 -0400 Received: by qgev79 with SMTP id v79so42682768qge.0 for ; Thu, 10 Sep 2015 11:19:05 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Thu, 10 Sep 2015 11:18:21 -0700 Message-Id: <1441909103-24666-10-git-send-email-rth@twiddle.net> In-Reply-To: <1441909103-24666-1-git-send-email-rth@twiddle.net> References: <1441909103-24666-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH v3 09/11] target-arm: Eliminate unnecessary zero-extend in disas_bitfield List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org For !SF, this initial ext32u can't be optimized away by the current TCG code generator. (It would require backward bit liveness propagation.) But since the range of bits for !SF are already constrained by unallocated_encoding, we'll never reference the high bits anyway. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index cf68754..56aa043 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -3015,7 +3015,11 @@ static void disas_bitfield(DisasContext *s, uint32_t insn) } tcg_rd = cpu_reg(s, rd); - tcg_tmp = read_cpu_reg(s, rn, sf); + + /* Suppress the zero-extend for !sf. Since RI and SI are constrained + to be smaller than bitsize, we'll never reference data outside the + low 32-bits anyway. */ + tcg_tmp = read_cpu_reg(s, rn, 1); /* Recognize the common aliases. */ if (opc == 0) { /* SBFM */ -- 2.4.3