Received: from eggs.gnu.org ([2001:4830:134:3::10]:52860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za6R3-0000J0-4N for qemu-devel@nongnu.org; Thu, 10 Sep 2015 14:19:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Za6R2-0001nJ-3T for qemu-devel@nongnu.org; Thu, 10 Sep 2015 14:19:01 -0400 Received: from mail-qk0-x22c.google.com ([2607:f8b0:400d:c09::22c]:35288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za6R1-0001nE-Nd for qemu-devel@nongnu.org; Thu, 10 Sep 2015 14:19:00 -0400 Received: by qkap81 with SMTP id p81so22061936qka.2 for ; Thu, 10 Sep 2015 11:18:59 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Thu, 10 Sep 2015 11:18:15 -0700 Message-Id: <1441909103-24666-4-git-send-email-rth@twiddle.net> In-Reply-To: <1441909103-24666-1-git-send-email-rth@twiddle.net> References: <1441909103-24666-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH v3 03/11] target-arm: Handle always condition codes within arm_test_cc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org Handling this with TCG_COND_ALWAYS will allow these unlikely cases to be handled without special cases in the rest of the translator. The TCG optimizer ought to be able to reduce these ALWAYS conditions completely. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-arm/translate.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/target-arm/translate.c b/target-arm/translate.c index 52452cf..3e7c367 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -804,6 +804,14 @@ void arm_test_cc(DisasCompare *cmp, int cc) tcg_gen_andc_i32(value, cpu_ZF, value); break; + case 14: /* always */ + case 15: /* always */ + /* Use the ALWAYS condition, which will fold early. + * It doesn't matter what we use for the value. */ + cond = TCG_COND_ALWAYS; + value = cpu_ZF; + goto no_invert; + default: fprintf(stderr, "Bad condition code 0x%x\n", cc); abort(); @@ -813,6 +821,7 @@ void arm_test_cc(DisasCompare *cmp, int cc) cond = tcg_invert_cond(cond); } + no_invert: cmp->cond = cond; cmp->value = value; cmp->value_global = global; -- 2.4.3