Received: from eggs.gnu.org ([2001:4830:134:3::10]:52924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za6R7-0000NL-Pp for qemu-devel@nongnu.org; Thu, 10 Sep 2015 14:19:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Za6R6-0001oe-9W for qemu-devel@nongnu.org; Thu, 10 Sep 2015 14:19:05 -0400 Received: from mail-qg0-x22d.google.com ([2607:f8b0:400d:c04::22d]:36058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za6R6-0001oP-39 for qemu-devel@nongnu.org; Thu, 10 Sep 2015 14:19:04 -0400 Received: by qgx61 with SMTP id 61so42809806qgx.3 for ; Thu, 10 Sep 2015 11:19:03 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Thu, 10 Sep 2015 11:18:19 -0700 Message-Id: <1441909103-24666-8-git-send-email-rth@twiddle.net> In-Reply-To: <1441909103-24666-1-git-send-email-rth@twiddle.net> References: <1441909103-24666-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH v3 07/11] target-arm: Recognize SXTB, SXTH, SXTW, ASR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org These are all special case aliases of SBFM. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index bb0d752..0572635 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -3017,7 +3017,28 @@ static void disas_bitfield(DisasContext *s, uint32_t insn) tcg_rd = cpu_reg(s, rd); tcg_tmp = read_cpu_reg(s, rn, sf); - /* OPTME: probably worth recognizing common cases of ext{8,16,32}{u,s} */ + /* Recognize the common aliases. */ + if (opc == 0) { /* SBFM */ + if (ri == 0) { + if (si == 7) { /* SXTB */ + tcg_gen_ext8s_i64(tcg_rd, tcg_tmp); + goto done; + } else if (si == 15) { /* SXTH */ + tcg_gen_ext16s_i64(tcg_rd, tcg_tmp); + goto done; + } else if (si == 31) { /* SXTW */ + tcg_gen_ext32s_i64(tcg_rd, tcg_tmp); + goto done; + } + } + if (si == 63 || (si == 31 && ri <= si)) { /* ASR */ + if (si == 31) { + tcg_gen_ext32s_i64(tcg_tmp, tcg_tmp); + } + tcg_gen_sari_i64(tcg_rd, tcg_tmp, ri); + goto done; + } + } if (opc != 1) { /* SBFM or UBFM */ tcg_gen_movi_i64(tcg_rd, 0); @@ -3042,6 +3063,7 @@ static void disas_bitfield(DisasContext *s, uint32_t insn) tcg_gen_sari_i64(tcg_rd, tcg_rd, 64 - (pos + len)); } + done: if (!sf) { /* zero extend final result */ tcg_gen_ext32u_i64(tcg_rd, tcg_rd); } -- 2.4.3