From: xuw2015@gmail.com Subject: [RESEND][PATCH] ovl: add O_LARGEFILE flag when copyup files Date: Fri, 11 Sep 2015 17:30:47 +0800 Message-ID: <1441963847-23133-1-git-send-email-xuw2015@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42826 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbbIKJaw (ORCPT ); Fri, 11 Sep 2015 05:30:52 -0400 Sender: linux-unionfs-owner@vger.kernel.org List-Id: linux-unionfs@vger.kernel.org To: alkisg@gmail.com, miklos@szeredi.hu, linux-unionfs@vger.kernel.org Cc: George Wang =46rom: George Wang now ovl only use O_RDONLY for lower and O_WRONLY for upper file. But if the file size larger than MAX_NON_LFS(1UL << 31 -1), will suffer -EOVERFLOW. We should add O_LARGEFILE flag to make it work. Following script can reproduct it: # cd $(mktemp -d) # mkdir lower upper work root # truncate -s 3G lower/sparse # mount -t overlay -o workdir=3Dwork,upperdir=3Dupper,lowerdir=3Dlower = overlay work # truncate -s 0 work/sparse truncate: cannot open =E2=80=98work/sparse=E2=80=99 for writing: Value = too large for defined data type Reported-by: Alkis Georgopoulos Signed-off-by: George Wang --- fs/overlayfs/copy_up.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c index 84d693d..e8ed965 100644 --- a/fs/overlayfs/copy_up.c +++ b/fs/overlayfs/copy_up.c @@ -81,11 +81,11 @@ static int ovl_copy_up_data(struct path *old, struc= t path *new, loff_t len) if (len =3D=3D 0) return 0; =20 - old_file =3D ovl_path_open(old, O_RDONLY); + old_file =3D ovl_path_open(old, O_RDONLY | O_LARGEFILE); if (IS_ERR(old_file)) return PTR_ERR(old_file); =20 - new_file =3D ovl_path_open(new, O_WRONLY); + new_file =3D ovl_path_open(new, O_WRONLY | O_LARGEFILE); if (IS_ERR(new_file)) { error =3D PTR_ERR(new_file); goto out_fput; --=20 1.8.3.1