Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 0F5E01A035C for ; Wed, 16 Sep 2015 14:49:10 +1000 (AEST) Message-ID: <1442378949.21531.1.camel@ellerman.id.au> Subject: Re: [PATCH] powerpc/mm: Recompute hash value after a failed update From: Michael Ellerman To: "Aneesh Kumar K.V" Cc: benh@kernel.crashing.org, paulus@samba.org, linuxppc-dev@lists.ozlabs.org Date: Wed, 16 Sep 2015 14:49:09 +1000 In-Reply-To: <87vbbbdp3g.fsf@linux.vnet.ibm.com> References: <1442300408-26490-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <87vbbbdp3g.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2015-09-16 at 08:53 +0530, Aneesh Kumar K.V wrote: > "Aneesh Kumar K.V" writes: > > > If we had secondary hash flag set, we ended up modifying hash value in > > the updatepp code path. Hence with a failed updatepp we will be using > > a wrong hash value for the following hash insert. Fix this by > > recomputing hash before insert. > > Without this patch we can end up with using wrong slot number in linux > pte. That can result in us missing an hash pte update or invalidate > which can cause memory corruption or even machine check ? Thanks. When did this break? Always? If so this should go to stable? cheers