Received: from eggs.gnu.org ([2001:4830:134:3::10]:38667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1HDV-0004Mu-Ue for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:17:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1HDS-0000LB-O0 for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:17:21 -0500 Received: from mx3-phx2.redhat.com ([209.132.183.24]:45853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1HDS-0000L5-G0 for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:17:18 -0500 Date: Tue, 24 Nov 2015 12:17:10 -0500 (EST) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <1442536458.16567531.1448385430286.JavaMail.zimbra@redhat.com> In-Reply-To: <1448384789-14830-5-git-send-email-armbru@redhat.com> References: <1448384789-14830-1-git-send-email-armbru@redhat.com> <1448384789-14830-5-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.5 4/5] ivshmem: Mark questionable socket type test FIXME List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: marcandre lureau , claudio fontana , qemu-devel@nongnu.org ----- Original Message ----- > Signed-off-by: Markus Armbruster > --- > hw/misc/ivshmem.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c > index 83d7bd3..a6bfdde 100644 > --- a/hw/misc/ivshmem.c > +++ b/hw/misc/ivshmem.c > @@ -939,6 +939,7 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error > **errp) > memory_region_add_subregion(&s->bar, 0, mr); > pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar); > } else if (s->server_chr !=3D NULL) { > + /* FIXME replace this test, it works basically by chance */ I wouldn't say it like that, but ack anyway. Reviewed-by: Marc-Andr=C3=A9 Lureau > if (strncmp(s->server_chr->filename, "unix:", 5)) { > error_setg(errp, "chardev is not a unix client socket"); > return; > -- > 2.4.3 >=20 >=20