Received: from eggs.gnu.org ([2001:4830:134:3::10]:34079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zh1bb-0007Dh-LW for qemu-devel@nongnu.org; Tue, 29 Sep 2015 16:34:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zh1bZ-0006tn-8v for qemu-devel@nongnu.org; Tue, 29 Sep 2015 16:34:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zh1bZ-0006tY-2C for qemu-devel@nongnu.org; Tue, 29 Sep 2015 16:34:29 -0400 From: Eduardo Habkost Date: Tue, 29 Sep 2015 17:34:22 -0300 Message-Id: <1443558863-26132-2-git-send-email-ehabkost@redhat.com> In-Reply-To: <1443558863-26132-1-git-send-email-ehabkost@redhat.com> References: <1443558863-26132-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] target-i386: Use 1UL for bit shift List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Richard Henderson Fix undefined behavior detected by clang runtime check: qemu/target-i386/cpu.c:1494:15: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' While doing that, add extra parenthesis for clarity. Reported-by: Peter Maydell Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 2b914b2..6af6db9 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1491,7 +1491,7 @@ static void report_unavailable_features(FeatureWord w, uint32_t mask) int i; for (i = 0; i < 32; ++i) { - if (1 << i & mask) { + if ((1UL << i) & mask) { const char *reg = get_register_name_32(f->cpuid_reg); assert(reg); fprintf(stderr, "warning: %s doesn't support requested feature: " -- 2.1.0