Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 077CC1A074F for ; Tue, 13 Oct 2015 16:10:07 +1100 (AEDT) Message-ID: <1444713006.29347.2.camel@ellerman.id.au> Subject: Re: [PATCH v3 10/31] powerpc/mm: Don't use pmd_val,pud_val and pgd_val as lvalue From: Michael Ellerman To: "Aneesh Kumar K.V" Cc: benh@kernel.crashing.org, paulus@samba.org, Scott Wood , linuxppc-dev@lists.ozlabs.org Date: Tue, 13 Oct 2015 16:10:06 +1100 In-Reply-To: <1444675215-19484-11-git-send-email-aneesh.kumar@linux.vnet.ibm.com> References: <1444675215-19484-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1444675215-19484-11-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2015-10-13 at 00:09 +0530, Aneesh Kumar K.V wrote: > We convert them static inline function here as we did with pte_val in > the previous patch This breaks ppc40x_defconfig & 40x/ep405_defconfig with: arch/powerpc/mm/40x_mmu.c: In function 'mmu_mapin_ram': arch/powerpc/mm/40x_mmu.c:113:20: error: lvalue required as left operand of assignment arch/powerpc/mm/40x_mmu.c:114:20: error: lvalue required as left operand of assignment arch/powerpc/mm/40x_mmu.c:115:20: error: lvalue required as left operand of assignment arch/powerpc/mm/40x_mmu.c:116:20: error: lvalue required as left operand of assignment arch/powerpc/mm/40x_mmu.c:128:18: error: lvalue required as left operand of assignment Which is mainly: pmd_val(*pmdp++) = val; The obvious patch to use pmd_set() doesn't work, I think because there's no pmd_set() defined for 32-bit nohash? cheers