Received: from eggs.gnu.org ([2001:4830:134:3::10]:33795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1H38-0002p7-9c for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:06:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1H33-0005l8-F8 for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:06:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1H33-0005kZ-8p for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:06:33 -0500 From: Markus Armbruster Date: Tue, 24 Nov 2015 18:06:28 +0100 Message-Id: <1448384789-14830-5-git-send-email-armbru@redhat.com> In-Reply-To: <1448384789-14830-1-git-send-email-armbru@redhat.com> References: <1448384789-14830-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH for-2.5 4/5] ivshmem: Mark questionable socket type test FIXME List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, claudio.fontana@huawei.com Signed-off-by: Markus Armbruster --- hw/misc/ivshmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 83d7bd3..a6bfdde 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -939,6 +939,7 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp) memory_region_add_subregion(&s->bar, 0, mr); pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar); } else if (s->server_chr != NULL) { + /* FIXME replace this test, it works basically by chance */ if (strncmp(s->server_chr->filename, "unix:", 5)) { error_setg(errp, "chardev is not a unix client socket"); return; -- 2.4.3