From: Sjoerd Simons Date: Tue, 08 Dec 2015 08:34:17 +0100 Subject: [U-Boot] [PATCH 6/7] mmc: mmc: Don't use sprintf when using tiny-printf In-Reply-To: References: <1449268061-805-1-git-send-email-sjoerd.simons@collabora.co.uk> <1449268061-805-7-git-send-email-sjoerd.simons@collabora.co.uk> Message-ID: <1449560057.2948.9.camel@collabora.co.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 2015-12-07 at 17:40 -0700, Simon Glass wrote: > On 4 December 2015 at 15:27, Sjoerd Simons > wrote: > > There is no sprintf implementation in tiny-printf, so don't try to > > use > > it when tiny-printf if used. > > > > Signed-off-by: Sjoerd Simons > > --- > > > > ?drivers/mmc/mmc.c | 4 +++- > > ?1 file changed, 3 insertions(+), 1 deletion(-) > > Acked-by: Simon Glass > Tested on firefly: > Tested-by: Simon Glass > > I can't help thinking that sprintf() would not add a lot more code... Probably not (it's write to buffer rather then write to output, so maybe just passing a function pointer for an out function in would just do the job). More work then I had time for though :/ Though i'm not sure it's worth it though (at least on firefly the spl won't output those fields) :) -- Sjoerd Simons Collabora Ltd.