From: Sjoerd Simons Date: Mon, 14 Dec 2015 08:38:27 +0100 Subject: [U-Boot] [PATCH 4/7] lib: Split panic functions out of vsprintf.c In-Reply-To: References: <1449268061-805-1-git-send-email-sjoerd.simons@collabora.co.uk> <1449268061-805-5-git-send-email-sjoerd.simons@collabora.co.uk> <1449559652.2948.3.camel@collabora.co.uk> <1449603391.15946.150.camel@freescale.com> Message-ID: <1450078707.17328.55.camel@collabora.co.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, 2015-12-13 at 20:45 -0700, Simon Glass wrote: > On 8 December 2015 at 12:38, Simon Glass wrote: > > Hi Scott, > > > > On 8 December 2015 at 12:36, Scott Wood > > wrote: > > > On Tue, 2015-12-08 at 12:34 -0700, Simon Glass wrote: > > > > Hi Sjoerd, > > > >? > > OK, so how about this: > > > > > > ifdef CONFIG_SPL_BUILD > > > > # SPL U-Boot may use full-printf, tiny-printf or none at all > > > > obj-$(CONFIG_SPL_SERIAL_SUPPORT) += panic.o strto.o > > > > > > ifdef CONFIG_USE_TINY_PRINTF > > obj-$(CONFIG_SPL_SERIAL_SUPPORT) += tiny-printf.o > > > > else > > obj-$(CONFIG_SPL_SERIAL_SUPPORT) += vsprintf.o > > > > endif > > > > else > > > > # Main U-Boot always uses the full printf support > > > > obj-y += vsprintf.o panic.o strto.o > > > > endif > > It's just a nit so I'm going to leave it as is for now. > > Applied to u-boot-rockchip, thanks! Heh, i just did an update series last night to send this morning :) lovely timing. I'll drop you some patches for these nits later this week while i still remember them :) (I agree your suggestion here is nicer). -- Sjoerd Simons Collabora Ltd.