From: Borislav Petkov Subject: [PATCH] drm, i915: Fix pointer size cast Date: Mon, 21 Dec 2015 19:53:59 +0100 Message-ID: <1450724039-23264-1-git-send-email-bp@alien8.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Sender: linux-kernel-owner@vger.kernel.org To: LKML Cc: Daniel Vetter , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org =46rom: Borislav Petkov gcc complains on 32-bit like this: drivers/gpu/drm/i915/intel_display.c: In function =E2=80=98intel_plan= e_obj_offset=E2=80=99: drivers/gpu/drm/i915/intel_display.c:2954:11: warning: cast to pointe= r from \ integer of different size [-Wint-to-pointer-cast] offset =3D (unsigned char *)vma->node.start; ^ because vma->node.start is u64 but a pointer on 32-bit is 4 bytes. Do the calculations with an unsigned long directly and save us the casts. Cc: Daniel Vetter Cc: Jani Nikula Cc: David Airlie Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Borislav Petkov --- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i91= 5/intel_display.c index 62211abe4922..640cb7c9b7f3 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -2941,7 +2941,7 @@ unsigned long intel_plane_obj_offset(struct intel= _plane *intel_plane, { const struct i915_ggtt_view *view =3D &i915_ggtt_view_normal; struct i915_vma *vma; - unsigned char *offset; + unsigned long offset; =20 if (intel_rotation_90_or_270(intel_plane->base.state->rotation)) view =3D &i915_ggtt_view_rotated; @@ -2951,14 +2951,14 @@ unsigned long intel_plane_obj_offset(struct int= el_plane *intel_plane, view->type)) return -1; =20 - offset =3D (unsigned char *)vma->node.start; + offset =3D vma->node.start; =20 if (plane =3D=3D 1) { offset +=3D vma->ggtt_view.rotation_info.uv_start_page * PAGE_SIZE; } =20 - return (unsigned long)offset; + return offset; } =20 static void skl_detach_scaler(struct intel_crtc *intel_crtc, int id) --=20 2.3.5