Received: from eggs.gnu.org ([2001:4830:134:3::10]:41654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aP9Qf-0004LT-MX for qemu-devel@nongnu.org; Fri, 29 Jan 2016 08:49:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aP9QZ-0001Pb-QM for qemu-devel@nongnu.org; Fri, 29 Jan 2016 08:49:37 -0500 From: Eric Blake Date: Fri, 29 Jan 2016 06:48:55 -0700 Message-Id: <1454075341-13658-20-git-send-email-eblake@redhat.com> In-Reply-To: <1454075341-13658-1-git-send-email-eblake@redhat.com> References: <1454075341-13658-1-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v10 19/25] qom: Swap 'name' next to visitor in ObjectPropertyAccessor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , "open list:nvme" , Eduardo Habkost , Paolo Bonzini , "Michael S. Tsirkin" , Jiri Slaby , Jason Wang , armbru@redhat.com, Alexander Graf , Keith Busch , Gonglei , "open list:sPAPR" , Gerd Hoffmann , Igor Mammedov , marcandre.lureau@redhat.com, David Gibson , John Snow , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Richard Henderson Similar to the previous patch, it's nice to have all functions in the tree that involve a visitor and a name for conversion to or from QAPI to consistently stick the 'name' parameter next to the Visitor parameter. Done by manually changing include/qom/object.h and qom/object.c, then running this Coccinelle script and touching up the fallout (Coccinelle insisted on adding some trailing whitespace). @ rule1 @ identifier fn; typedef Object, Visitor, Error; identifier obj, v, opaque, name, errp; @@ void fn - (Object *obj, Visitor *v, void *opaque, const char *name, + (Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { ... } @@ identifier rule1.fn; expression obj, v, opaque, name, errp; @@ fn(obj, v, - opaque, name, + name, opaque, errp) Signed-off-by: Eric Blake Reviewed-by: Marc-Andr=C3=A9 Lureau --- v10: redo Coccinelle script with 'typedef' instead of type; net result is the same so R-b retained v9: typo fix in commit message, rebase to master context v8: new patch --- include/qom/object.h | 4 +- backends/hostmem.c | 16 +++--- bootdevice.c | 8 +-- hw/acpi/ich9.c | 35 +++++------- hw/block/nvme.c | 8 +-- hw/core/machine.c | 14 ++--- hw/core/qdev-properties-system.c | 32 +++++------ hw/core/qdev-properties.c | 116 +++++++++++++++++++--------------= ------ hw/core/qdev.c | 5 +- hw/i386/pc.c | 29 +++++----- hw/ide/qdev.c | 8 +-- hw/intc/xics.c | 12 ++-- hw/isa/lpc_ich9.c | 5 +- hw/mem/pc-dimm.c | 4 +- hw/misc/edu.c | 4 +- hw/misc/tmp105.c | 8 +-- hw/net/ne2000-isa.c | 10 ++-- hw/pci-host/piix.c | 10 ++-- hw/pci-host/q35.c | 13 ++--- hw/ppc/spapr_drc.c | 16 +++--- hw/usb/dev-storage.c | 8 +-- hw/virtio/virtio-balloon.c | 8 +-- memory.c | 18 +++--- net/dump.c | 8 +-- net/filter-buffer.c | 10 ++-- qom/object.c | 75 +++++++++++++------------ target-i386/cpu.c | 67 +++++++++++----------- target-ppc/translate_init.c | 8 +-- tests/test-qdev-global-props.c | 14 ++--- 29 files changed, 282 insertions(+), 291 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h index 3e7e99d..698827d 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -290,16 +290,16 @@ typedef struct InterfaceInfo InterfaceInfo; * ObjectPropertyAccessor: * @obj: the object that owns the property * @v: the visitor that contains the property data + * @name: the name of the property * @opaque: the object property opaque - * @name: the name of the property * @errp: a pointer to an Error that is filled if getting/setting fails. * * Called when trying to get/set a property. */ typedef void (ObjectPropertyAccessor)(Object *obj, Visitor *v, - void *opaque, const char *name, + void *opaque, Error **errp); /** diff --git a/backends/hostmem.c b/backends/hostmem.c index a9d30d8..2657907 100644 --- a/backends/hostmem.c +++ b/backends/hostmem.c @@ -26,8 +26,8 @@ QEMU_BUILD_BUG_ON(HOST_MEM_POLICY_INTERLEAVE !=3D MPOL_= INTERLEAVE); #endif static void -host_memory_backend_get_size(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +host_memory_backend_get_size(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { HostMemoryBackend *backend =3D MEMORY_BACKEND(obj); uint64_t value =3D backend->size; @@ -36,8 +36,8 @@ host_memory_backend_get_size(Object *obj, Visitor *v, v= oid *opaque, } static void -host_memory_backend_set_size(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +host_memory_backend_set_size(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { HostMemoryBackend *backend =3D MEMORY_BACKEND(obj); Error *local_err =3D NULL; @@ -63,8 +63,8 @@ out: } static void -host_memory_backend_get_host_nodes(Object *obj, Visitor *v, void *opaque= , - const char *name, Error **errp) +host_memory_backend_get_host_nodes(Object *obj, Visitor *v, const char *= name, + void *opaque, Error **errp) { HostMemoryBackend *backend =3D MEMORY_BACKEND(obj); uint16List *host_nodes =3D NULL; @@ -95,8 +95,8 @@ host_memory_backend_get_host_nodes(Object *obj, Visitor= *v, void *opaque, } static void -host_memory_backend_set_host_nodes(Object *obj, Visitor *v, void *opaque= , - const char *name, Error **errp) +host_memory_backend_set_host_nodes(Object *obj, Visitor *v, const char *= name, + void *opaque, Error **errp) { #ifdef CONFIG_NUMA HostMemoryBackend *backend =3D MEMORY_BACKEND(obj); diff --git a/bootdevice.c b/bootdevice.c index d307cfc..56e5baf 100644 --- a/bootdevice.c +++ b/bootdevice.c @@ -270,15 +270,15 @@ typedef struct { DeviceState *dev; } BootIndexProperty; -static void device_get_bootindex(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void device_get_bootindex(Object *obj, Visitor *v, const char *na= me, + void *opaque, Error **errp) { BootIndexProperty *prop =3D opaque; visit_type_int32(v, name, prop->bootindex, errp); } -static void device_set_bootindex(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void device_set_bootindex(Object *obj, Visitor *v, const char *na= me, + void *opaque, Error **errp) { BootIndexProperty *prop =3D opaque; int32_t boot_index; diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 0a486fb..3efdce7 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -282,9 +282,8 @@ void ich9_pm_init(PCIDevice *lpc_pci, ICH9LPCPMRegs *= pm, } } -static void ich9_pm_get_gpe0_blk(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) +static void ich9_pm_get_gpe0_blk(Object *obj, Visitor *v, const char *na= me, + void *opaque, Error **errp) { ICH9LPCPMRegs *pm =3D opaque; uint32_t value =3D pm->pm_io_base + ICH9_PMIO_GPE0_STS; @@ -307,9 +306,8 @@ static void ich9_pm_set_memory_hotplug_support(Object= *obj, bool value, s->pm.acpi_memory_hotplug.is_enabled =3D value; } -static void ich9_pm_get_disable_s3(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) +static void ich9_pm_get_disable_s3(Object *obj, Visitor *v, const char *= name, + void *opaque, Error **errp) { ICH9LPCPMRegs *pm =3D opaque; uint8_t value =3D pm->disable_s3; @@ -317,9 +315,8 @@ static void ich9_pm_get_disable_s3(Object *obj, Visit= or *v, visit_type_uint8(v, name, &value, errp); } -static void ich9_pm_set_disable_s3(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) +static void ich9_pm_set_disable_s3(Object *obj, Visitor *v, const char *= name, + void *opaque, Error **errp) { ICH9LPCPMRegs *pm =3D opaque; Error *local_err =3D NULL; @@ -334,9 +331,8 @@ out: error_propagate(errp, local_err); } -static void ich9_pm_get_disable_s4(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) +static void ich9_pm_get_disable_s4(Object *obj, Visitor *v, const char *= name, + void *opaque, Error **errp) { ICH9LPCPMRegs *pm =3D opaque; uint8_t value =3D pm->disable_s4; @@ -344,9 +340,8 @@ static void ich9_pm_get_disable_s4(Object *obj, Visit= or *v, visit_type_uint8(v, name, &value, errp); } -static void ich9_pm_set_disable_s4(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) +static void ich9_pm_set_disable_s4(Object *obj, Visitor *v, const char *= name, + void *opaque, Error **errp) { ICH9LPCPMRegs *pm =3D opaque; Error *local_err =3D NULL; @@ -361,9 +356,8 @@ out: error_propagate(errp, local_err); } -static void ich9_pm_get_s4_val(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) +static void ich9_pm_get_s4_val(Object *obj, Visitor *v, const char *name= , + void *opaque, Error **errp) { ICH9LPCPMRegs *pm =3D opaque; uint8_t value =3D pm->s4_val; @@ -371,9 +365,8 @@ static void ich9_pm_get_s4_val(Object *obj, Visitor *= v, visit_type_uint8(v, name, &value, errp); } -static void ich9_pm_set_s4_val(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) +static void ich9_pm_set_s4_val(Object *obj, Visitor *v, const char *name= , + void *opaque, Error **errp) { ICH9LPCPMRegs *pm =3D opaque; Error *local_err =3D NULL; diff --git a/hw/block/nvme.c b/hw/block/nvme.c index a10068a..778f5a6 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -916,16 +916,16 @@ static void nvme_class_init(ObjectClass *oc, void *= data) dc->vmsd =3D &nvme_vmstate; } -static void nvme_get_bootindex(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void nvme_get_bootindex(Object *obj, Visitor *v, const char *name= , + void *opaque, Error **errp) { NvmeCtrl *s =3D NVME(obj); visit_type_int32(v, name, &s->conf.bootindex, errp); } -static void nvme_set_bootindex(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void nvme_set_bootindex(Object *obj, Visitor *v, const char *name= , + void *opaque, Error **errp) { NvmeCtrl *s =3D NVME(obj); int32_t boot_index; diff --git a/hw/core/machine.c b/hw/core/machine.c index 0fd1e73..3ec3efa 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -33,7 +33,7 @@ static void machine_set_accel(Object *obj, const char *= value, Error **errp) } static void machine_set_kernel_irqchip(Object *obj, Visitor *v, - void *opaque, const char *name, + const char *name, void *opaque, Error **errp) { Error *err =3D NULL; @@ -68,7 +68,7 @@ static void machine_set_kernel_irqchip(Object *obj, Vis= itor *v, } static void machine_get_kvm_shadow_mem(Object *obj, Visitor *v, - void *opaque, const char *name, + const char *name, void *opaque, Error **errp) { MachineState *ms =3D MACHINE(obj); @@ -78,7 +78,7 @@ static void machine_get_kvm_shadow_mem(Object *obj, Vis= itor *v, } static void machine_set_kvm_shadow_mem(Object *obj, Visitor *v, - void *opaque, const char *name, + const char *name, void *opaque, Error **errp) { MachineState *ms =3D MACHINE(obj); @@ -170,8 +170,8 @@ static void machine_set_dumpdtb(Object *obj, const ch= ar *value, Error **errp) } static void machine_get_phandle_start(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) + const char *name, void *opaque, + Error **errp) { MachineState *ms =3D MACHINE(obj); int64_t value =3D ms->phandle_start; @@ -180,8 +180,8 @@ static void machine_get_phandle_start(Object *obj, Vi= sitor *v, } static void machine_set_phandle_start(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) + const char *name, void *opaque, + Error **errp) { MachineState *ms =3D MACHINE(obj); Error *error =3D NULL; diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-s= ystem.c index 86e0b02..0f0e472 100644 --- a/hw/core/qdev-properties-system.c +++ b/hw/core/qdev-properties-system.c @@ -111,14 +111,14 @@ static char *print_drive(void *ptr) return g_strdup(blk_name(ptr)); } -static void get_drive(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void get_drive(Object *obj, Visitor *v, const char *name, void *o= paque, + Error **errp) { get_pointer(obj, v, opaque, print_drive, name, errp); } -static void set_drive(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_drive(Object *obj, Visitor *v, const char *name, void *o= paque, + Error **errp) { set_pointer(obj, v, opaque, parse_drive, name, errp); } @@ -172,14 +172,14 @@ static char *print_chr(void *ptr) return g_strdup(val); } -static void get_chr(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void get_chr(Object *obj, Visitor *v, const char *name, void *opa= que, + Error **errp) { get_pointer(obj, v, opaque, print_chr, name, errp); } -static void set_chr(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_chr(Object *obj, Visitor *v, const char *name, void *opa= que, + Error **errp) { set_pointer(obj, v, opaque, parse_chr, name, errp); } @@ -193,8 +193,8 @@ PropertyInfo qdev_prop_chr =3D { }; /* --- netdev device --- */ -static void get_netdev(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void get_netdev(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -205,8 +205,8 @@ static void get_netdev(Object *obj, Visitor *v, void = *opaque, g_free(p); } -static void set_netdev(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_netdev(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -292,8 +292,8 @@ static int print_vlan(DeviceState *dev, Property *pro= p, char *dest, size_t len) return snprintf(dest, len, ""); } -static void get_vlan(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void get_vlan(Object *obj, Visitor *v, const char *name, void *op= aque, + Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -310,8 +310,8 @@ static void get_vlan(Object *obj, Visitor *v, void *o= paque, visit_type_int32(v, name, &id, errp); } -static void set_vlan(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_vlan(Object *obj, Visitor *v, const char *name, void *op= aque, + Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index 0626a8a..9104645 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -41,8 +41,8 @@ void *qdev_get_prop_ptr(DeviceState *dev, Property *pro= p) return ptr; } -static void get_enum(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void get_enum(Object *obj, Visitor *v, const char *name, void *op= aque, + Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -52,8 +52,8 @@ static void get_enum(Object *obj, Visitor *v, void *opa= que, prop->info->name, errp); } -static void set_enum(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_enum(Object *obj, Visitor *v, const char *name, void *op= aque, + Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -87,8 +87,8 @@ static void bit_prop_set(DeviceState *dev, Property *pr= ops, bool val) } } -static void prop_get_bit(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void prop_get_bit(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -98,8 +98,8 @@ static void prop_get_bit(Object *obj, Visitor *v, void = *opaque, visit_type_bool(v, name, &value, errp); } -static void prop_set_bit(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void prop_set_bit(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -145,8 +145,8 @@ static void bit64_prop_set(DeviceState *dev, Property= *props, bool val) } } -static void prop_get_bit64(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void prop_get_bit64(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -156,8 +156,8 @@ static void prop_get_bit64(Object *obj, Visitor *v, v= oid *opaque, visit_type_bool(v, name, &value, errp); } -static void prop_set_bit64(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void prop_set_bit64(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -186,8 +186,8 @@ PropertyInfo qdev_prop_bit64 =3D { /* --- bool --- */ -static void get_bool(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void get_bool(Object *obj, Visitor *v, const char *name, void *op= aque, + Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -196,8 +196,8 @@ static void get_bool(Object *obj, Visitor *v, void *o= paque, visit_type_bool(v, name, ptr, errp); } -static void set_bool(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_bool(Object *obj, Visitor *v, const char *name, void *op= aque, + Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -219,8 +219,8 @@ PropertyInfo qdev_prop_bool =3D { /* --- 8bit integer --- */ -static void get_uint8(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void get_uint8(Object *obj, Visitor *v, const char *name, void *o= paque, + Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -229,8 +229,8 @@ static void get_uint8(Object *obj, Visitor *v, void *= opaque, visit_type_uint8(v, name, ptr, errp); } -static void set_uint8(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_uint8(Object *obj, Visitor *v, const char *name, void *o= paque, + Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -252,8 +252,8 @@ PropertyInfo qdev_prop_uint8 =3D { /* --- 16bit integer --- */ -static void get_uint16(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void get_uint16(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -262,8 +262,8 @@ static void get_uint16(Object *obj, Visitor *v, void = *opaque, visit_type_uint16(v, name, ptr, errp); } -static void set_uint16(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_uint16(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -285,8 +285,8 @@ PropertyInfo qdev_prop_uint16 =3D { /* --- 32bit integer --- */ -static void get_uint32(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void get_uint32(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -295,8 +295,8 @@ static void get_uint32(Object *obj, Visitor *v, void = *opaque, visit_type_uint32(v, name, ptr, errp); } -static void set_uint32(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_uint32(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -310,8 +310,8 @@ static void set_uint32(Object *obj, Visitor *v, void = *opaque, visit_type_uint32(v, name, ptr, errp); } -static void get_int32(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void get_int32(Object *obj, Visitor *v, const char *name, void *o= paque, + Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -320,8 +320,8 @@ static void get_int32(Object *obj, Visitor *v, void *= opaque, visit_type_int32(v, name, ptr, errp); } -static void set_int32(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_int32(Object *obj, Visitor *v, const char *name, void *o= paque, + Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -349,8 +349,8 @@ PropertyInfo qdev_prop_int32 =3D { /* --- 64bit integer --- */ -static void get_uint64(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void get_uint64(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -359,8 +359,8 @@ static void get_uint64(Object *obj, Visitor *v, void = *opaque, visit_type_uint64(v, name, ptr, errp); } -static void set_uint64(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_uint64(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -388,8 +388,8 @@ static void release_string(Object *obj, const char *n= ame, void *opaque) g_free(*(char **)qdev_get_prop_ptr(DEVICE(obj), prop)); } -static void get_string(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void get_string(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -403,8 +403,8 @@ static void get_string(Object *obj, Visitor *v, void = *opaque, } } -static void set_string(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_string(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -447,8 +447,8 @@ PropertyInfo qdev_prop_ptr =3D { * 01:02:03:04:05:06 * 01-02-03-04-05-06 */ -static void get_mac(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void get_mac(Object *obj, Visitor *v, const char *name, void *opa= que, + Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -463,8 +463,8 @@ static void get_mac(Object *obj, Visitor *v, void *op= aque, visit_type_str(v, name, &p, errp); } -static void set_mac(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_mac(Object *obj, Visitor *v, const char *name, void *opa= que, + Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -557,8 +557,8 @@ PropertyInfo qdev_prop_fdc_drive_type =3D { /* * bus-local address, i.e. "$slot" or "$slot.$fn" */ -static void set_pci_devfn(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_pci_devfn(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -628,8 +628,8 @@ PropertyInfo qdev_prop_pci_devfn =3D { /* --- blocksize --- */ -static void set_blocksize(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_blocksize(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -675,8 +675,8 @@ PropertyInfo qdev_prop_blocksize =3D { /* --- pci host address --- */ -static void get_pci_host_devaddr(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void get_pci_host_devaddr(Object *obj, Visitor *v, const char *na= me, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -696,8 +696,8 @@ static void get_pci_host_devaddr(Object *obj, Visitor= *v, void *opaque, * Parse [:]:. * if is not supplied, it's assumed to be 0. */ -static void set_pci_host_devaddr(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_pci_host_devaddr(Object *obj, Visitor *v, const char *na= me, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -810,8 +810,8 @@ static void array_element_release(Object *obj, const = char *name, void *opaque) g_free(p); } -static void set_prop_arraylen(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_prop_arraylen(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { /* Setter for the property which defines the length of a * variable-sized property array. As well as actually setting the @@ -1093,8 +1093,8 @@ void qdev_prop_set_globals(DeviceState *dev) /* --- 64bit unsigned int 'size' type --- */ -static void get_size(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void get_size(Object *obj, Visitor *v, const char *name, void *op= aque, + Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; @@ -1103,8 +1103,8 @@ static void get_size(Object *obj, Visitor *v, void = *opaque, visit_type_size(v, name, ptr, errp); } -static void set_size(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void set_size(Object *obj, Visitor *v, const char *name, void *op= aque, + Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 7edeb64..1424e5c 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -893,8 +893,9 @@ char *qdev_get_dev_path(DeviceState *dev) * Legacy property handling */ -static void qdev_get_legacy_property(Object *obj, Visitor *v, void *opaq= ue, - const char *name, Error **errp) +static void qdev_get_legacy_property(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) { DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 1d34afe..c0d1af0 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1755,8 +1755,9 @@ static HotplugHandler *pc_get_hotpug_handler(Machin= eState *machine, } static void -pc_machine_get_hotplug_memory_region_size(Object *obj, Visitor *v, void = *opaque, - const char *name, Error **errp= ) +pc_machine_get_hotplug_memory_region_size(Object *obj, Visitor *v, + const char *name, void *opaque= , + Error **errp) { PCMachineState *pcms =3D PC_MACHINE(obj); int64_t value =3D memory_region_size(&pcms->hotplug_memory.mr); @@ -1765,8 +1766,8 @@ pc_machine_get_hotplug_memory_region_size(Object *o= bj, Visitor *v, void *opaque, } static void pc_machine_get_max_ram_below_4g(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) + const char *name, void *opaq= ue, + Error **errp) { PCMachineState *pcms =3D PC_MACHINE(obj); uint64_t value =3D pcms->max_ram_below_4g; @@ -1775,8 +1776,8 @@ static void pc_machine_get_max_ram_below_4g(Object = *obj, Visitor *v, } static void pc_machine_set_max_ram_below_4g(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) + const char *name, void *opaq= ue, + Error **errp) { PCMachineState *pcms =3D PC_MACHINE(obj); Error *error =3D NULL; @@ -1804,8 +1805,8 @@ static void pc_machine_set_max_ram_below_4g(Object = *obj, Visitor *v, pcms->max_ram_below_4g =3D value; } -static void pc_machine_get_vmport(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void pc_machine_get_vmport(Object *obj, Visitor *v, const char *n= ame, + void *opaque, Error **errp) { PCMachineState *pcms =3D PC_MACHINE(obj); OnOffAuto vmport =3D pcms->vmport; @@ -1813,8 +1814,8 @@ static void pc_machine_get_vmport(Object *obj, Visi= tor *v, void *opaque, visit_type_OnOffAuto(v, name, &vmport, errp); } -static void pc_machine_set_vmport(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void pc_machine_set_vmport(Object *obj, Visitor *v, const char *n= ame, + void *opaque, Error **errp) { PCMachineState *pcms =3D PC_MACHINE(obj); @@ -1846,8 +1847,8 @@ bool pc_machine_is_smm_enabled(PCMachineState *pcms= ) return false; } -static void pc_machine_get_smm(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void pc_machine_get_smm(Object *obj, Visitor *v, const char *name= , + void *opaque, Error **errp) { PCMachineState *pcms =3D PC_MACHINE(obj); OnOffAuto smm =3D pcms->smm; @@ -1855,8 +1856,8 @@ static void pc_machine_get_smm(Object *obj, Visitor= *v, void *opaque, visit_type_OnOffAuto(v, name, &smm, errp); } -static void pc_machine_set_smm(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void pc_machine_set_smm(Object *obj, Visitor *v, const char *name= , + void *opaque, Error **errp) { PCMachineState *pcms =3D PC_MACHINE(obj); diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c index 0110eca..8135c15 100644 --- a/hw/ide/qdev.c +++ b/hw/ide/qdev.c @@ -199,16 +199,16 @@ static int ide_dev_initfn(IDEDevice *dev, IDEDriveK= ind kind) return 0; } -static void ide_dev_get_bootindex(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void ide_dev_get_bootindex(Object *obj, Visitor *v, const char *n= ame, + void *opaque, Error **errp) { IDEDevice *d =3D IDE_DEVICE(obj); visit_type_int32(v, name, &d->conf.bootindex, errp); } -static void ide_dev_set_bootindex(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void ide_dev_set_bootindex(Object *obj, Visitor *v, const char *n= ame, + void *opaque, Error **errp) { IDEDevice *d =3D IDE_DEVICE(obj); int32_t boot_index; diff --git a/hw/intc/xics.c b/hw/intc/xics.c index 502c87f..ba7c40f 100644 --- a/hw/intc/xics.c +++ b/hw/intc/xics.c @@ -88,8 +88,8 @@ static void xics_common_reset(DeviceState *d) device_reset(DEVICE(icp->ics)); } -static void xics_prop_get_nr_irqs(Object *obj, Visitor *v, - void *opaque, const char *name, Error = **errp) +static void xics_prop_get_nr_irqs(Object *obj, Visitor *v, const char *n= ame, + void *opaque, Error **errp) { XICSState *icp =3D XICS_COMMON(obj); int64_t value =3D icp->nr_irqs; @@ -97,8 +97,8 @@ static void xics_prop_get_nr_irqs(Object *obj, Visitor = *v, visit_type_int(v, name, &value, errp); } -static void xics_prop_set_nr_irqs(Object *obj, Visitor *v, - void *opaque, const char *name, Error = **errp) +static void xics_prop_set_nr_irqs(Object *obj, Visitor *v, const char *n= ame, + void *opaque, Error **errp) { XICSState *icp =3D XICS_COMMON(obj); XICSStateClass *info =3D XICS_COMMON_GET_CLASS(icp); @@ -122,7 +122,7 @@ static void xics_prop_set_nr_irqs(Object *obj, Visito= r *v, } static void xics_prop_get_nr_servers(Object *obj, Visitor *v, - void *opaque, const char *name, + const char *name, void *opaque, Error **errp) { XICSState *icp =3D XICS_COMMON(obj); @@ -132,7 +132,7 @@ static void xics_prop_get_nr_servers(Object *obj, Vis= itor *v, } static void xics_prop_set_nr_servers(Object *obj, Visitor *v, - void *opaque, const char *name, + const char *name, void *opaque, Error **errp) { XICSState *icp =3D XICS_COMMON(obj); diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index 358f707..b9ae1da 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -569,9 +569,8 @@ Object *ich9_lpc_find(void) return o; } -static void ich9_lpc_get_sci_int(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) +static void ich9_lpc_get_sci_int(Object *obj, Visitor *v, const char *na= me, + void *opaque, Error **errp) { ICH9LPCState *lpc =3D ICH9_LPC_DEVICE(obj); uint32_t value =3D ich9_lpc_sci_irq(lpc); diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c index 123baeb..c52bf09 100644 --- a/hw/mem/pc-dimm.c +++ b/hw/mem/pc-dimm.c @@ -372,8 +372,8 @@ static Property pc_dimm_properties[] =3D { DEFINE_PROP_END_OF_LIST(), }; -static void pc_dimm_get_size(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void pc_dimm_get_size(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { int64_t value; MemoryRegion *mr; diff --git a/hw/misc/edu.c b/hw/misc/edu.c index 4a3dc76..b6c83ce 100644 --- a/hw/misc/edu.c +++ b/hw/misc/edu.c @@ -362,8 +362,8 @@ static void pci_edu_uninit(PCIDevice *pdev) timer_del(&edu->dma_timer); } -static void edu_obj_uint64(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void edu_obj_uint64(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { uint64_t *val =3D opaque; diff --git a/hw/misc/tmp105.c b/hw/misc/tmp105.c index 1850315..a9ac524 100644 --- a/hw/misc/tmp105.c +++ b/hw/misc/tmp105.c @@ -52,8 +52,8 @@ static void tmp105_alarm_update(TMP105State *s) tmp105_interrupt_update(s); } -static void tmp105_get_temperature(Object *obj, Visitor *v, void *opaque= , - const char *name, Error **errp) +static void tmp105_get_temperature(Object *obj, Visitor *v, const char *= name, + void *opaque, Error **errp) { TMP105State *s =3D TMP105(obj); int64_t value =3D s->temperature * 1000 / 256; @@ -64,8 +64,8 @@ static void tmp105_get_temperature(Object *obj, Visitor= *v, void *opaque, /* Units are 0.001 centigrades relative to 0 C. s->temperature is 8.8 * fixed point, so units are 1/256 centigrades. A simple ratio will do. */ -static void tmp105_set_temperature(Object *obj, Visitor *v, void *opaque= , - const char *name, Error **errp) +static void tmp105_set_temperature(Object *obj, Visitor *v, const char *= name, + void *opaque, Error **errp) { TMP105State *s =3D TMP105(obj); Error *local_err =3D NULL; diff --git a/hw/net/ne2000-isa.c b/hw/net/ne2000-isa.c index 46ef304..630cab3 100644 --- a/hw/net/ne2000-isa.c +++ b/hw/net/ne2000-isa.c @@ -93,8 +93,9 @@ static void isa_ne2000_class_initfn(ObjectClass *klass,= void *data) set_bit(DEVICE_CATEGORY_NETWORK, dc->categories); } -static void isa_ne2000_get_bootindex(Object *obj, Visitor *v, void *opaq= ue, - const char *name, Error **errp) +static void isa_ne2000_get_bootindex(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) { ISANE2000State *isa =3D ISA_NE2000(obj); NE2000State *s =3D &isa->ne2000; @@ -102,8 +103,9 @@ static void isa_ne2000_get_bootindex(Object *obj, Vis= itor *v, void *opaque, visit_type_int32(v, name, &s->c.bootindex, errp); } -static void isa_ne2000_set_bootindex(Object *obj, Visitor *v, void *opaq= ue, - const char *name, Error **errp) +static void isa_ne2000_set_bootindex(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) { ISANE2000State *isa =3D ISA_NE2000(obj); NE2000State *s =3D &isa->ne2000; diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index dbae0aa..b5f59af 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -215,7 +215,7 @@ static const VMStateDescription vmstate_i440fx =3D { }; static void i440fx_pcihost_get_pci_hole_start(Object *obj, Visitor *v, - void *opaque, const char *= name, + const char *name, void *op= aque, Error **errp) { I440FXState *s =3D I440FX_PCI_HOST_BRIDGE(obj); @@ -225,7 +225,7 @@ static void i440fx_pcihost_get_pci_hole_start(Object = *obj, Visitor *v, } static void i440fx_pcihost_get_pci_hole_end(Object *obj, Visitor *v, - void *opaque, const char *na= me, + const char *name, void *opaq= ue, Error **errp) { I440FXState *s =3D I440FX_PCI_HOST_BRIDGE(obj); @@ -235,8 +235,8 @@ static void i440fx_pcihost_get_pci_hole_end(Object *o= bj, Visitor *v, } static void i440fx_pcihost_get_pci_hole64_start(Object *obj, Visitor *v, - void *opaque, const char= *name, - Error **errp) + const char *name, + void *opaque, Error **er= rp) { PCIHostState *h =3D PCI_HOST_BRIDGE(obj); Range w64; @@ -247,7 +247,7 @@ static void i440fx_pcihost_get_pci_hole64_start(Objec= t *obj, Visitor *v, } static void i440fx_pcihost_get_pci_hole64_end(Object *obj, Visitor *v, - void *opaque, const char *= name, + const char *name, void *op= aque, Error **errp) { PCIHostState *h =3D PCI_HOST_BRIDGE(obj); diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 2b3608a..23b78cc 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -67,7 +67,7 @@ static const char *q35_host_root_bus_path(PCIHostState = *host_bridge, } static void q35_host_get_pci_hole_start(Object *obj, Visitor *v, - void *opaque, const char *name, + const char *name, void *opaque, Error **errp) { Q35PCIHost *s =3D Q35_HOST_DEVICE(obj); @@ -77,7 +77,7 @@ static void q35_host_get_pci_hole_start(Object *obj, Vi= sitor *v, } static void q35_host_get_pci_hole_end(Object *obj, Visitor *v, - void *opaque, const char *name, + const char *name, void *opaque, Error **errp) { Q35PCIHost *s =3D Q35_HOST_DEVICE(obj); @@ -87,7 +87,7 @@ static void q35_host_get_pci_hole_end(Object *obj, Visi= tor *v, } static void q35_host_get_pci_hole64_start(Object *obj, Visitor *v, - void *opaque, const char *name= , + const char *name, void *opaque= , Error **errp) { PCIHostState *h =3D PCI_HOST_BRIDGE(obj); @@ -99,7 +99,7 @@ static void q35_host_get_pci_hole64_start(Object *obj, = Visitor *v, } static void q35_host_get_pci_hole64_end(Object *obj, Visitor *v, - void *opaque, const char *name, + const char *name, void *opaque, Error **errp) { PCIHostState *h =3D PCI_HOST_BRIDGE(obj); @@ -110,9 +110,8 @@ static void q35_host_get_pci_hole64_end(Object *obj, = Visitor *v, visit_type_uint64(v, name, &w64.end, errp); } -static void q35_host_get_mmcfg_size(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) +static void q35_host_get_mmcfg_size(Object *obj, Visitor *v, const char = *name, + void *opaque, Error **errp) { PCIExpressHost *e =3D PCIE_HOST_BRIDGE(obj); uint32_t value =3D e->size; diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index 9c8fbe8..9ef603b 100644 --- a/hw/ppc/spapr_drc.c +++ b/hw/ppc/spapr_drc.c @@ -214,8 +214,8 @@ static uint32_t entity_sense(sPAPRDRConnector *drc, s= PAPRDREntitySense *state) return RTAS_OUT_SUCCESS; } -static void prop_get_index(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void prop_get_index(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { sPAPRDRConnector *drc =3D SPAPR_DR_CONNECTOR(obj); sPAPRDRConnectorClass *drck =3D SPAPR_DR_CONNECTOR_GET_CLASS(drc); @@ -223,8 +223,8 @@ static void prop_get_index(Object *obj, Visitor *v, v= oid *opaque, visit_type_uint32(v, name, &value, errp); } -static void prop_get_type(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void prop_get_type(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { sPAPRDRConnector *drc =3D SPAPR_DR_CONNECTOR(obj); sPAPRDRConnectorClass *drck =3D SPAPR_DR_CONNECTOR_GET_CLASS(drc); @@ -239,8 +239,8 @@ static char *prop_get_name(Object *obj, Error **errp) return g_strdup(drck->get_name(drc)); } -static void prop_get_entity_sense(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void prop_get_entity_sense(Object *obj, Visitor *v, const char *n= ame, + void *opaque, Error **errp) { sPAPRDRConnector *drc =3D SPAPR_DR_CONNECTOR(obj); sPAPRDRConnectorClass *drck =3D SPAPR_DR_CONNECTOR_GET_CLASS(drc); @@ -250,8 +250,8 @@ static void prop_get_entity_sense(Object *obj, Visito= r *v, void *opaque, visit_type_uint32(v, name, &value, errp); } -static void prop_get_fdt(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void prop_get_fdt(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { sPAPRDRConnector *drc =3D SPAPR_DR_CONNECTOR(obj); Error *err =3D NULL; diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index 3261446..e743551 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -780,8 +780,8 @@ static void usb_msd_class_initfn_storage(ObjectClass = *klass, void *data) dc->props =3D msd_properties; } -static void usb_msd_get_bootindex(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void usb_msd_get_bootindex(Object *obj, Visitor *v, const char *n= ame, + void *opaque, Error **errp) { USBDevice *dev =3D USB_DEVICE(obj); MSDState *s =3D USB_STORAGE_DEV(dev); @@ -789,8 +789,8 @@ static void usb_msd_get_bootindex(Object *obj, Visito= r *v, void *opaque, visit_type_int32(v, name, &s->conf.bootindex, errp); } -static void usb_msd_set_bootindex(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void usb_msd_set_bootindex(Object *obj, Visitor *v, const char *n= ame, + void *opaque, Error **errp) { USBDevice *dev =3D USB_DEVICE(obj); MSDState *s =3D USB_STORAGE_DEV(dev); diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index ad78c4c..c8a104e 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virtio/virtio-balloon.c @@ -110,8 +110,8 @@ static void balloon_stats_poll_cb(void *opaque) virtio_notify(vdev, s->svq); } -static void balloon_stats_get_all(Object *obj, Visitor *v, - void *opaque, const char *name, Error = **errp) +static void balloon_stats_get_all(Object *obj, Visitor *v, const char *n= ame, + void *opaque, Error **errp) { Error *err =3D NULL; VirtIOBalloon *s =3D opaque; @@ -149,7 +149,7 @@ out: } static void balloon_stats_get_poll_interval(Object *obj, Visitor *v, - void *opaque, const char *na= me, + const char *name, void *opaq= ue, Error **errp) { VirtIOBalloon *s =3D opaque; @@ -157,7 +157,7 @@ static void balloon_stats_get_poll_interval(Object *o= bj, Visitor *v, } static void balloon_stats_set_poll_interval(Object *obj, Visitor *v, - void *opaque, const char *na= me, + const char *name, void *opaq= ue, Error **errp) { VirtIOBalloon *s =3D opaque; diff --git a/memory.c b/memory.c index ae3ff0c..b90c0d3 100644 --- a/memory.c +++ b/memory.c @@ -928,8 +928,8 @@ void memory_region_init(MemoryRegion *mr, } } -static void memory_region_get_addr(Object *obj, Visitor *v, void *opaque= , - const char *name, Error **errp) +static void memory_region_get_addr(Object *obj, Visitor *v, const char *= name, + void *opaque, Error **errp) { MemoryRegion *mr =3D MEMORY_REGION(obj); uint64_t value =3D mr->addr; @@ -937,8 +937,9 @@ static void memory_region_get_addr(Object *obj, Visit= or *v, void *opaque, visit_type_uint64(v, name, &value, errp); } -static void memory_region_get_container(Object *obj, Visitor *v, void *o= paque, - const char *name, Error **errp) +static void memory_region_get_container(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) { MemoryRegion *mr =3D MEMORY_REGION(obj); gchar *path =3D (gchar *)""; @@ -960,8 +961,9 @@ static Object *memory_region_resolve_container(Object= *obj, void *opaque, return OBJECT(mr->container); } -static void memory_region_get_priority(Object *obj, Visitor *v, void *op= aque, - const char *name, Error **errp) +static void memory_region_get_priority(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) { MemoryRegion *mr =3D MEMORY_REGION(obj); int32_t value =3D mr->priority; @@ -976,8 +978,8 @@ static bool memory_region_get_may_overlap(Object *obj= , Error **errp) return mr->may_overlap; } -static void memory_region_get_size(Object *obj, Visitor *v, void *opaque= , - const char *name, Error **errp) +static void memory_region_get_size(Object *obj, Visitor *v, const char *= name, + void *opaque, Error **errp) { MemoryRegion *mr =3D MEMORY_REGION(obj); uint64_t value =3D memory_region_size(mr); diff --git a/net/dump.c b/net/dump.c index 0aac9b8..760a12d 100644 --- a/net/dump.c +++ b/net/dump.c @@ -271,8 +271,8 @@ static void filter_dump_setup(NetFilterState *nf, Err= or **errp) net_dump_state_init(&nfds->ds, nfds->filename, nfds->maxlen, errp); } -static void filter_dump_get_maxlen(Object *obj, Visitor *v, void *opaque= , - const char *name, Error **errp) +static void filter_dump_get_maxlen(Object *obj, Visitor *v, const char *= name, + void *opaque, Error **errp) { NetFilterDumpState *nfds =3D FILTER_DUMP(obj); uint32_t value =3D nfds->maxlen; @@ -280,8 +280,8 @@ static void filter_dump_get_maxlen(Object *obj, Visit= or *v, void *opaque, visit_type_uint32(v, name, &value, errp); } -static void filter_dump_set_maxlen(Object *obj, Visitor *v, void *opaque= , - const char *name, Error **errp) +static void filter_dump_set_maxlen(Object *obj, Visitor *v, const char *= name, + void *opaque, Error **errp) { NetFilterDumpState *nfds =3D FILTER_DUMP(obj); Error *local_err =3D NULL; diff --git a/net/filter-buffer.c b/net/filter-buffer.c index 3173d26..570d342 100644 --- a/net/filter-buffer.c +++ b/net/filter-buffer.c @@ -132,8 +132,9 @@ static void filter_buffer_class_init(ObjectClass *oc,= void *data) nfc->receive_iov =3D filter_buffer_receive_iov; } -static void filter_buffer_get_interval(Object *obj, Visitor *v, void *op= aque, - const char *name, Error **errp) +static void filter_buffer_get_interval(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) { FilterBufferState *s =3D FILTER_BUFFER(obj); uint32_t value =3D s->interval; @@ -141,8 +142,9 @@ static void filter_buffer_get_interval(Object *obj, V= isitor *v, void *opaque, visit_type_uint32(v, name, &value, errp); } -static void filter_buffer_set_interval(Object *obj, Visitor *v, void *op= aque, - const char *name, Error **errp) +static void filter_buffer_set_interval(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) { FilterBufferState *s =3D FILTER_BUFFER(obj); Error *local_err =3D NULL; diff --git a/qom/object.c b/qom/object.c index 6a5ad59..55b3955 100644 --- a/qom/object.c +++ b/qom/object.c @@ -1061,7 +1061,7 @@ void object_property_get(Object *obj, Visitor *v, c= onst char *name, if (!prop->get) { error_setg(errp, QERR_PERMISSION_DENIED); } else { - prop->get(obj, v, prop->opaque, name, errp); + prop->get(obj, v, name, prop->opaque, errp); } } @@ -1076,7 +1076,7 @@ void object_property_set(Object *obj, Visitor *v, c= onst char *name, if (!prop->set) { error_setg(errp, QERR_PERMISSION_DENIED); } else { - prop->set(obj, v, prop->opaque, name, errp); + prop->set(obj, v, name, prop->opaque, errp); } } @@ -1334,8 +1334,9 @@ Object *object_get_objects_root(void) return container_get(object_get_root(), "/objects"); } -static void object_get_child_property(Object *obj, Visitor *v, void *opa= que, - const char *name, Error **errp) +static void object_get_child_property(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) { Object *child =3D opaque; gchar *path; @@ -1403,8 +1404,9 @@ typedef struct { ObjectPropertyLinkFlags flags; } LinkProperty; -static void object_get_link_property(Object *obj, Visitor *v, void *opaq= ue, - const char *name, Error **errp) +static void object_get_link_property(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) { LinkProperty *lprop =3D opaque; Object **child =3D lprop->child; @@ -1460,8 +1462,9 @@ static Object *object_resolve_link(Object *obj, con= st char *name, return target; } -static void object_set_link_property(Object *obj, Visitor *v, void *opaq= ue, - const char *name, Error **errp) +static void object_set_link_property(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) { Error *local_err =3D NULL; LinkProperty *prop =3D opaque; @@ -1724,8 +1727,8 @@ typedef struct StringProperty void (*set)(Object *, const char *, Error **); } StringProperty; -static void property_get_str(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void property_get_str(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { StringProperty *prop =3D opaque; char *value; @@ -1741,8 +1744,8 @@ static void property_get_str(Object *obj, Visitor *= v, void *opaque, g_free(value); } -static void property_set_str(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void property_set_str(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { StringProperty *prop =3D opaque; char *value; @@ -1816,8 +1819,8 @@ typedef struct BoolProperty void (*set)(Object *, bool, Error **); } BoolProperty; -static void property_get_bool(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void property_get_bool(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { BoolProperty *prop =3D opaque; bool value; @@ -1832,8 +1835,8 @@ static void property_get_bool(Object *obj, Visitor = *v, void *opaque, visit_type_bool(v, name, &value, errp); } -static void property_set_bool(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void property_set_bool(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { BoolProperty *prop =3D opaque; bool value; @@ -1899,8 +1902,8 @@ void object_class_property_add_bool(ObjectClass *kl= ass, const char *name, } } -static void property_get_enum(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void property_get_enum(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { EnumProperty *prop =3D opaque; int value; @@ -1915,8 +1918,8 @@ static void property_get_enum(Object *obj, Visitor = *v, void *opaque, visit_type_enum(v, name, &value, prop->strings, NULL, errp); } -static void property_set_enum(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void property_set_enum(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { EnumProperty *prop =3D opaque; int value; @@ -1991,8 +1994,8 @@ typedef struct TMProperty { void (*get)(Object *, struct tm *, Error **); } TMProperty; -static void property_get_tm(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void property_get_tm(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { TMProperty *prop =3D opaque; Error *err =3D NULL; @@ -2090,33 +2093,29 @@ static char *qdev_get_type(Object *obj, Error **e= rrp) return g_strdup(object_get_typename(obj)); } -static void property_get_uint8_ptr(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) +static void property_get_uint8_ptr(Object *obj, Visitor *v, const char *= name, + void *opaque, Error **errp) { uint8_t value =3D *(uint8_t *)opaque; visit_type_uint8(v, name, &value, errp); } -static void property_get_uint16_ptr(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) +static void property_get_uint16_ptr(Object *obj, Visitor *v, const char = *name, + void *opaque, Error **errp) { uint16_t value =3D *(uint16_t *)opaque; visit_type_uint16(v, name, &value, errp); } -static void property_get_uint32_ptr(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) +static void property_get_uint32_ptr(Object *obj, Visitor *v, const char = *name, + void *opaque, Error **errp) { uint32_t value =3D *(uint32_t *)opaque; visit_type_uint32(v, name, &value, errp); } -static void property_get_uint64_ptr(Object *obj, Visitor *v, - void *opaque, const char *name, - Error **errp) +static void property_get_uint64_ptr(Object *obj, Visitor *v, const char = *name, + void *opaque, Error **errp) { uint64_t value =3D *(uint64_t *)opaque; visit_type_uint64(v, name, &value, errp); @@ -2183,16 +2182,16 @@ typedef struct { char *target_name; } AliasProperty; -static void property_get_alias(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void property_get_alias(Object *obj, Visitor *v, const char *name= , + void *opaque, Error **errp) { AliasProperty *prop =3D opaque; object_property_get(prop->target_obj, v, prop->target_name, errp); } -static void property_set_alias(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void property_set_alias(Object *obj, Visitor *v, const char *name= , + void *opaque, Error **errp) { AliasProperty *prop =3D opaque; diff --git a/target-i386/cpu.c b/target-i386/cpu.c index c9b8b16..3fa14bf 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1530,8 +1530,9 @@ static void report_unavailable_features(FeatureWord= w, uint32_t mask) } } -static void x86_cpuid_version_get_family(Object *obj, Visitor *v, void *= opaque, - const char *name, Error **errp) +static void x86_cpuid_version_get_family(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) { X86CPU *cpu =3D X86_CPU(obj); CPUX86State *env =3D &cpu->env; @@ -1544,8 +1545,9 @@ static void x86_cpuid_version_get_family(Object *ob= j, Visitor *v, void *opaque, visit_type_int(v, name, &value, errp); } -static void x86_cpuid_version_set_family(Object *obj, Visitor *v, void *= opaque, - const char *name, Error **errp) +static void x86_cpuid_version_set_family(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) { X86CPU *cpu =3D X86_CPU(obj); CPUX86State *env =3D &cpu->env; @@ -1573,8 +1575,9 @@ static void x86_cpuid_version_set_family(Object *ob= j, Visitor *v, void *opaque, } } -static void x86_cpuid_version_get_model(Object *obj, Visitor *v, void *o= paque, - const char *name, Error **errp) +static void x86_cpuid_version_get_model(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) { X86CPU *cpu =3D X86_CPU(obj); CPUX86State *env =3D &cpu->env; @@ -1585,8 +1588,9 @@ static void x86_cpuid_version_get_model(Object *obj= , Visitor *v, void *opaque, visit_type_int(v, name, &value, errp); } -static void x86_cpuid_version_set_model(Object *obj, Visitor *v, void *o= paque, - const char *name, Error **errp) +static void x86_cpuid_version_set_model(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) { X86CPU *cpu =3D X86_CPU(obj); CPUX86State *env =3D &cpu->env; @@ -1611,7 +1615,7 @@ static void x86_cpuid_version_set_model(Object *obj= , Visitor *v, void *opaque, } static void x86_cpuid_version_get_stepping(Object *obj, Visitor *v, - void *opaque, const char *nam= e, + const char *name, void *opaqu= e, Error **errp) { X86CPU *cpu =3D X86_CPU(obj); @@ -1623,7 +1627,7 @@ static void x86_cpuid_version_get_stepping(Object *= obj, Visitor *v, } static void x86_cpuid_version_set_stepping(Object *obj, Visitor *v, - void *opaque, const char *nam= e, + const char *name, void *opaqu= e, Error **errp) { X86CPU *cpu =3D X86_CPU(obj); @@ -1719,8 +1723,8 @@ static void x86_cpuid_set_model_id(Object *obj, con= st char *model_id, } } -static void x86_cpuid_get_tsc_freq(Object *obj, Visitor *v, void *opaque= , - const char *name, Error **errp) +static void x86_cpuid_get_tsc_freq(Object *obj, Visitor *v, const char *= name, + void *opaque, Error **errp) { X86CPU *cpu =3D X86_CPU(obj); int64_t value; @@ -1729,8 +1733,8 @@ static void x86_cpuid_get_tsc_freq(Object *obj, Vis= itor *v, void *opaque, visit_type_int(v, name, &value, errp); } -static void x86_cpuid_set_tsc_freq(Object *obj, Visitor *v, void *opaque= , - const char *name, Error **errp) +static void x86_cpuid_set_tsc_freq(Object *obj, Visitor *v, const char *= name, + void *opaque, Error **errp) { X86CPU *cpu =3D X86_CPU(obj); const int64_t min =3D 0; @@ -1752,8 +1756,8 @@ static void x86_cpuid_set_tsc_freq(Object *obj, Vis= itor *v, void *opaque, cpu->env.tsc_khz =3D cpu->env.user_tsc_khz =3D value / 1000; } -static void x86_cpuid_get_apic_id(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void x86_cpuid_get_apic_id(Object *obj, Visitor *v, const char *n= ame, + void *opaque, Error **errp) { X86CPU *cpu =3D X86_CPU(obj); int64_t value =3D cpu->apic_id; @@ -1761,8 +1765,8 @@ static void x86_cpuid_get_apic_id(Object *obj, Visi= tor *v, void *opaque, visit_type_int(v, name, &value, errp); } -static void x86_cpuid_set_apic_id(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void x86_cpuid_set_apic_id(Object *obj, Visitor *v, const char *n= ame, + void *opaque, Error **errp) { X86CPU *cpu =3D X86_CPU(obj); DeviceState *dev =3D DEVICE(obj); @@ -1797,8 +1801,9 @@ static void x86_cpuid_set_apic_id(Object *obj, Visi= tor *v, void *opaque, } /* Generic getter for "feature-words" and "filtered-features" properties= */ -static void x86_cpu_get_feature_words(Object *obj, Visitor *v, void *opa= que, - const char *name, Error **errp) +static void x86_cpu_get_feature_words(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) { uint32_t *array =3D (uint32_t *)opaque; FeatureWord w; @@ -1826,8 +1831,8 @@ static void x86_cpu_get_feature_words(Object *obj, = Visitor *v, void *opaque, error_propagate(errp, err); } -static void x86_get_hv_spinlocks(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void x86_get_hv_spinlocks(Object *obj, Visitor *v, const char *na= me, + void *opaque, Error **errp) { X86CPU *cpu =3D X86_CPU(obj); int64_t value =3D cpu->hyperv_spinlock_attempts; @@ -1835,8 +1840,8 @@ static void x86_get_hv_spinlocks(Object *obj, Visit= or *v, void *opaque, visit_type_int(v, name, &value, errp); } -static void x86_set_hv_spinlocks(Object *obj, Visitor *v, void *opaque, - const char *name, Error **errp) +static void x86_set_hv_spinlocks(Object *obj, Visitor *v, const char *na= me, + void *opaque, Error **errp) { const int64_t min =3D 0xFFF; const int64_t max =3D UINT_MAX; @@ -2944,22 +2949,16 @@ typedef struct BitProperty { uint32_t mask; } BitProperty; -static void x86_cpu_get_bit_prop(Object *obj, - Visitor *v, - void *opaque, - const char *name, - Error **errp) +static void x86_cpu_get_bit_prop(Object *obj, Visitor *v, const char *na= me, + void *opaque, Error **errp) { BitProperty *fp =3D opaque; bool value =3D (*fp->ptr & fp->mask) =3D=3D fp->mask; visit_type_bool(v, name, &value, errp); } -static void x86_cpu_set_bit_prop(Object *obj, - Visitor *v, - void *opaque, - const char *name, - Error **errp) +static void x86_cpu_set_bit_prop(Object *obj, Visitor *v, const char *na= me, + void *opaque, Error **errp) { DeviceState *dev =3D DEVICE(obj); BitProperty *fp =3D opaque; diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 6c643fc..fae6ece 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/translate_init.c @@ -8034,8 +8034,8 @@ POWERPC_FAMILY(POWER5P)(ObjectClass *oc, void *data= ) pcc->l1_icache_size =3D 0x10000; } -static void powerpc_get_compat(Object *obj, Visitor *v, - void *opaque, const char *name, Error **e= rrp) +static void powerpc_get_compat(Object *obj, Visitor *v, const char *name= , + void *opaque, Error **errp) { char *value =3D (char *)""; Property *prop =3D opaque; @@ -8062,8 +8062,8 @@ static void powerpc_get_compat(Object *obj, Visitor= *v, visit_type_str(v, name, &value, errp); } -static void powerpc_set_compat(Object *obj, Visitor *v, - void *opaque, const char *name, Error **e= rrp) +static void powerpc_set_compat(Object *obj, Visitor *v, const char *name= , + void *opaque, Error **errp) { Error *error =3D NULL; char *value =3D NULL; diff --git a/tests/test-qdev-global-props.c b/tests/test-qdev-global-prop= s.c index e728611..07c1823 100644 --- a/tests/test-qdev-global-props.c +++ b/tests/test-qdev-global-props.c @@ -116,22 +116,16 @@ static void test_static_globalprop(void) #define TYPE_UNUSED_HOTPLUG "hotplug-type" #define TYPE_UNUSED_NOHOTPLUG "nohotplug-type" -static void prop1_accessor(Object *obj, - Visitor *v, - void *opaque, - const char *name, - Error **errp) +static void prop1_accessor(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { MyType *mt =3D DYNAMIC_TYPE(obj); visit_type_uint32(v, name, &mt->prop1, errp); } -static void prop2_accessor(Object *obj, - Visitor *v, - void *opaque, - const char *name, - Error **errp) +static void prop2_accessor(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) { MyType *mt =3D DYNAMIC_TYPE(obj); --=20 2.5.0