From: Eric Anholt Subject: [PATCH 3/5] drm/vc4: Return an ERR_PTR from BO creation instead of NULL. Date: Thu, 4 Feb 2016 11:23:09 -0800 Message-ID: <1454613791-29049-4-git-send-email-eric@anholt.net> References: <1454613791-29049-1-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1454613791-29049-1-git-send-email-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Rml4ZXMgaWd0IHZjNF9jcmVhdGVfYm8vY3JlYXRlLWJvLTAgYnkgcmV0dXJuaW5nIC1FSU5WQUwg ZnJvbSB0aGUKaW9jdGwgaW5zdGVhZCBvZiAtRU5PTUVNLgoKU2lnbmVkLW9mZi1ieTogRXJpYyBB bmhvbHQgPGVyaWNAYW5ob2x0Lm5ldD4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9iby5j ICAgICAgICB8IDE2ICsrKysrKysrLS0tLS0tLS0KIGRyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2dl bS5jICAgICAgIHwgIDQgKystLQogZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfaXJxLmMgICAgICAg fCAgMiArLQogZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfcmVuZGVyX2NsLmMgfCAgNCArKy0tCiBk cml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF92YWxpZGF0ZS5jICB8ICA0ICsrLS0KIDUgZmlsZXMgY2hh bmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL3ZjNC92YzRfYm8uYyBiL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2JvLmMK aW5kZXggMThkZmUzZS4uMjIyNzhiYyAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL3ZjNC92 YzRfYm8uYworKysgYi9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9iby5jCkBAIC0yMTUsNyArMjE1 LDcgQEAgc3RydWN0IHZjNF9ibyAqdmM0X2JvX2NyZWF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LCBzaXplX3QgdW5hbGlnbmVkX3NpemUsCiAJc3RydWN0IGRybV9nZW1fY21hX29iamVjdCAqY21h X29iajsKIAogCWlmIChzaXplID09IDApCi0JCXJldHVybiBOVUxMOworCQlyZXR1cm4gRVJSX1BU UigtRUlOVkFMKTsKIAogCS8qIEZpcnN0LCB0cnkgdG8gZ2V0IGEgdmM0X2JvIGZyb20gdGhlIGtl cm5lbCBCTyBjYWNoZS4gKi8KIAlpZiAoZnJvbV9jYWNoZSkgewpAQCAtMjM3LDcgKzIzNyw3IEBA IHN0cnVjdCB2YzRfYm8gKnZjNF9ib19jcmVhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc2l6 ZV90IHVuYWxpZ25lZF9zaXplLAogCQlpZiAoSVNfRVJSKGNtYV9vYmopKSB7CiAJCQlEUk1fRVJS T1IoIkZhaWxlZCB0byBhbGxvY2F0ZSBmcm9tIENNQTpcbiIpOwogCQkJdmM0X2JvX3N0YXRzX2R1 bXAodmM0KTsKLQkJCXJldHVybiBOVUxMOworCQkJcmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7CiAJ CX0KIAl9CiAKQEAgLTI1OSw4ICsyNTksOCBAQCBpbnQgdmM0X2R1bWJfY3JlYXRlKHN0cnVjdCBk cm1fZmlsZSAqZmlsZV9wcml2LAogCQlhcmdzLT5zaXplID0gYXJncy0+cGl0Y2ggKiBhcmdzLT5o ZWlnaHQ7CiAKIAlibyA9IHZjNF9ib19jcmVhdGUoZGV2LCBhcmdzLT5zaXplLCBmYWxzZSk7Ci0J aWYgKCFibykKLQkJcmV0dXJuIC1FTk9NRU07CisJaWYgKElTX0VSUihibykpCisJCXJldHVybiBQ VFJfRVJSKGJvKTsKIAogCXJldCA9IGRybV9nZW1faGFuZGxlX2NyZWF0ZShmaWxlX3ByaXYsICZi by0+YmFzZS5iYXNlLCAmYXJncy0+aGFuZGxlKTsKIAlkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5j ZV91bmxvY2tlZCgmYm8tPmJhc2UuYmFzZSk7CkBAIC00NDMsOCArNDQzLDggQEAgaW50IHZjNF9j cmVhdGVfYm9faW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKIAkgKiBn ZXQgemVyb2VkLCBhbmQgdGhhdCBtaWdodCBsZWFrIGRhdGEgYmV0d2VlbiB1c2Vycy4KIAkgKi8K IAlibyA9IHZjNF9ib19jcmVhdGUoZGV2LCBhcmdzLT5zaXplLCBmYWxzZSk7Ci0JaWYgKCFibykK LQkJcmV0dXJuIC1FTk9NRU07CisJaWYgKElTX0VSUihibykpCisJCXJldHVybiBQVFJfRVJSKGJv KTsKIAogCXJldCA9IGRybV9nZW1faGFuZGxlX2NyZWF0ZShmaWxlX3ByaXYsICZiby0+YmFzZS5i YXNlLCAmYXJncy0+aGFuZGxlKTsKIAlkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZV91bmxvY2tl ZCgmYm8tPmJhc2UuYmFzZSk7CkBAIC00OTYsOCArNDk2LDggQEAgdmM0X2NyZWF0ZV9zaGFkZXJf Ym9faW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKIAl9CiAKIAlibyA9 IHZjNF9ib19jcmVhdGUoZGV2LCBhcmdzLT5zaXplLCB0cnVlKTsKLQlpZiAoIWJvKQotCQlyZXR1 cm4gLUVOT01FTTsKKwlpZiAoSVNfRVJSKGJvKSkKKwkJcmV0dXJuIFBUUl9FUlIoYm8pOwogCiAJ cmV0ID0gY29weV9mcm9tX3VzZXIoYm8tPmJhc2UudmFkZHIsCiAJCQkgICAgICh2b2lkIF9fdXNl ciAqKSh1aW50cHRyX3QpYXJncy0+ZGF0YSwKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92 YzQvdmM0X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfZ2VtLmMKaW5kZXggY2M4OWZm Yy4uM2JmNjc5ZCAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfZ2VtLmMKKysr IGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfZ2VtLmMKQEAgLTU3OCw5ICs1NzgsOSBAQCB2YzRf Z2V0X2JjbChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgdmM0X2V4ZWNfaW5mbyAqZXhl YykKIAl9CiAKIAlibyA9IHZjNF9ib19jcmVhdGUoZGV2LCBleGVjX3NpemUsIHRydWUpOwotCWlm ICghYm8pIHsKKwlpZiAoSVNfRVJSKGJvKSkgewogCQlEUk1fRVJST1IoIkNvdWxkbid0IGFsbG9j YXRlIEJPIGZvciBiaW5uaW5nXG4iKTsKLQkJcmV0ID0gLUVOT01FTTsKKwkJcmV0ID0gUFRSX0VS Uihibyk7CiAJCWdvdG8gZmFpbDsKIAl9CiAJZXhlYy0+ZXhlY19ibyA9ICZiby0+YmFzZTsKZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2lycS5jIGIvZHJpdmVycy9ncHUvZHJt L3ZjNC92YzRfaXJxLmMKaW5kZXggYjY4MDYwZS4uNzhhMjEzNSAxMDA2NDQKLS0tIGEvZHJpdmVy cy9ncHUvZHJtL3ZjNC92YzRfaXJxLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfaXJx LmMKQEAgLTU3LDcgKzU3LDcgQEAgdmM0X292ZXJmbG93X21lbV93b3JrKHN0cnVjdCB3b3JrX3N0 cnVjdCAqd29yaykKIAlzdHJ1Y3QgdmM0X2JvICpibzsKIAogCWJvID0gdmM0X2JvX2NyZWF0ZShk ZXYsIDI1NiAqIDEwMjQsIHRydWUpOwotCWlmICghYm8pIHsKKwlpZiAoSVNfRVJSKGJvKSkgewog CQlEUk1fRVJST1IoIkNvdWxkbid0IGFsbG9jYXRlIGJpbm5lciBvdmVyZmxvdyBtZW1cbiIpOwog CQlyZXR1cm47CiAJfQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfcmVuZGVy X2NsLmMgYi9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9yZW5kZXJfY2wuYwppbmRleCBkZWE5N2Y0 Li4wZjEyNDE4IDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9yZW5kZXJfY2wu YworKysgYi9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9yZW5kZXJfY2wuYwpAQCAtMzE2LDggKzMx Niw4IEBAIHN0YXRpYyBpbnQgdmM0X2NyZWF0ZV9yY2xfYm8oc3RydWN0IGRybV9kZXZpY2UgKmRl diwgc3RydWN0IHZjNF9leGVjX2luZm8gKmV4ZWMsCiAJc2l6ZSArPSB4dGlsZXMgKiB5dGlsZXMg KiBsb29wX2JvZHlfc2l6ZTsKIAogCXNldHVwLT5yY2wgPSAmdmM0X2JvX2NyZWF0ZShkZXYsIHNp emUsIHRydWUpLT5iYXNlOwotCWlmICghc2V0dXAtPnJjbCkKLQkJcmV0dXJuIC1FTk9NRU07CisJ aWYgKElTX0VSUihzZXR1cC0+cmNsKSkKKwkJcmV0dXJuIFBUUl9FUlIoc2V0dXAtPnJjbCk7CiAJ bGlzdF9hZGRfdGFpbCgmdG9fdmM0X2JvKCZzZXR1cC0+cmNsLT5iYXNlKS0+dW5yZWZfaGVhZCwK IAkJICAgICAgJmV4ZWMtPnVucmVmX2xpc3QpOwogCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vdmM0L3ZjNF92YWxpZGF0ZS5jIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfdmFsaWRhdGUu YwppbmRleCBlMjZkOWY2Li4yNGMyYzc0IDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vdmM0 L3ZjNF92YWxpZGF0ZS5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X3ZhbGlkYXRlLmMK QEAgLTQwMSw4ICs0MDEsOCBAQCB2YWxpZGF0ZV90aWxlX2Jpbm5pbmdfY29uZmlnKFZBTElEQVRF X0FSR1MpCiAJdGlsZV9ibyA9IHZjNF9ib19jcmVhdGUoZGV2LCBleGVjLT50aWxlX2FsbG9jX29m ZnNldCArIHRpbGVfYWxsb2Nfc2l6ZSwKIAkJCQl0cnVlKTsKIAlleGVjLT50aWxlX2JvID0gJnRp bGVfYm8tPmJhc2U7Ci0JaWYgKCFleGVjLT50aWxlX2JvKQotCQlyZXR1cm4gLUVOT01FTTsKKwlp ZiAoSVNfRVJSKGV4ZWMtPnRpbGVfYm8pKQorCQlyZXR1cm4gUFRSX0VSUihleGVjLT50aWxlX2Jv KTsKIAlsaXN0X2FkZF90YWlsKCZ0aWxlX2JvLT51bnJlZl9oZWFkLCAmZXhlYy0+dW5yZWZfbGlz dCk7CiAKIAkvKiB0aWxlIGFsbG9jIGFkZHJlc3MuICovCi0tIAoyLjcuMAoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK