Received: from eggs.gnu.org ([2001:4830:134:3::10]:54925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVz4R-0005MR-0B for qemu-devel@nongnu.org; Wed, 17 Feb 2016 05:10:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVz4N-0004xQ-9A for qemu-devel@nongnu.org; Wed, 17 Feb 2016 05:10:54 -0500 From: "Daniel P. Berrange" Date: Wed, 17 Feb 2016 10:10:21 +0000 Message-Id: <1455703823-12159-7-git-send-email-berrange@redhat.com> In-Reply-To: <1455703823-12159-1-git-send-email-berrange@redhat.com> References: <1455703823-12159-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PATCH v7 6/8] qemu-nbd: don't overlap long option values with short options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org When defining values for long options, the normal practice is to start numbering from 256, to avoid overlap with the range of valid values for short options. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qemu-nbd.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index 424e71f..9ccfc13 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -37,13 +37,13 @@ #include #define SOCKET_PATH "/var/lock/qemu-nbd-%s" -#define QEMU_NBD_OPT_CACHE 1 -#define QEMU_NBD_OPT_AIO 2 -#define QEMU_NBD_OPT_DISCARD 3 -#define QEMU_NBD_OPT_DETECT_ZEROES 4 -#define QEMU_NBD_OPT_OBJECT 5 -#define QEMU_NBD_OPT_TLSCREDS 6 -#define QEMU_NBD_OPT_IMAGE_OPTS 7 +#define QEMU_NBD_OPT_CACHE 256 +#define QEMU_NBD_OPT_AIO 257 +#define QEMU_NBD_OPT_DISCARD 258 +#define QEMU_NBD_OPT_DETECT_ZEROES 259 +#define QEMU_NBD_OPT_OBJECT 260 +#define QEMU_NBD_OPT_TLSCREDS 261 +#define QEMU_NBD_OPT_IMAGE_OPTS 262 static NBDExport *exp; static bool newproto; -- 2.5.0