Received: from eggs.gnu.org ([2001:4830:134:3::10]:54039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW6l6-0002ql-C0 for qemu-devel@nongnu.org; Wed, 17 Feb 2016 13:23:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW6l1-0001Ls-CQ for qemu-devel@nongnu.org; Wed, 17 Feb 2016 13:23:28 -0500 From: Thomas Huth Date: Wed, 17 Feb 2016 19:23:19 +0100 Message-Id: <1455733399-4939-1-git-send-email-thuth@redhat.com> Subject: [Qemu-devel] [PATCH] hw/ppc/spapr: Halt CPU when powering off via RTAS call List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au Cc: drjones@redhat.com, qemu-devel@nongnu.org, agraf@suse.de The LoPAPR specification defines the following for the RTAS power-off call: "On successful operation, does not return". However, the implementation in QEMU currently returns and runs the guest CPU again for some more cycles. This caused some trouble with the new ppc implementation of the kvm-unit-tests recently. So let's make sure that the QEMU implementation follows the spec, thus stop the CPU to make sure that the RTAS call does not return to the guest anymore. Signed-off-by: Thomas Huth --- hw/ppc/spapr_rtas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c index 07ad672..b7c5ebd 100644 --- a/hw/ppc/spapr_rtas.c +++ b/hw/ppc/spapr_rtas.c @@ -113,6 +113,7 @@ static void rtas_power_off(PowerPCCPU *cpu, sPAPRMachineState *spapr, return; } qemu_system_shutdown_request(); + cpu_stop_current(); rtas_st(rets, 0, RTAS_OUT_SUCCESS); } -- 1.8.3.1