Return-Path: Received: from casper.infradead.org ([85.118.1.10]:42706 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754705AbcBZRxR (ORCPT ); Fri, 26 Feb 2016 12:53:17 -0500 From: Christoph Hellwig To: viro@zeniv.linux.org.uk Cc: darrick.wong@oracle.com, linux-fsdevel@vger.kernel.org Subject: [PATCH] fs: return -EOPNOTSUPP if clone is not supported Date: Fri, 26 Feb 2016 18:53:12 +0100 Message-Id: <1456509192-5608-2-git-send-email-hch@lst.de> In-Reply-To: <1456509192-5608-1-git-send-email-hch@lst.de> References: <1456509192-5608-1-git-send-email-hch@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: -EBADF is a rather confusing error if an operations is not supported, and nfsd gets rather upset about it. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index 324ec27..1cdfdfe 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -1532,10 +1532,12 @@ int vfs_clone_file_range(struct file *file_in, loff_t pos_in, if (!(file_in->f_mode & FMODE_READ) || !(file_out->f_mode & FMODE_WRITE) || - (file_out->f_flags & O_APPEND) || - !file_in->f_op->clone_file_range) + (file_out->f_flags & O_APPEND)) return -EBADF; + if (!file_in->f_op->clone_file_range) + return -EOPNOTSUPP; + ret = clone_verify_area(file_in, pos_in, len, false); if (ret) return ret; -- 2.1.4