Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3qpFnw6J01zDq5f for ; Mon, 18 Apr 2016 14:40:52 +1000 (AEST) Message-ID: <1460954445.21777.0.camel@ellerman.id.au> Subject: Re: [1/3] powerpc: scan_features() updates incorrect bits From: Michael Ellerman To: anton@samba.org, Alexey Kardashevskiy , Paul Mackerras , Benjamin Herrenschmidt , Michael Neuling , David Gibson , Alexander Graf , matt@ozlabs.org Cc: linuxppc-dev@lists.ozlabs.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org Date: Mon, 18 Apr 2016 14:40:45 +1000 In-Reply-To: <3qmfyk6wGYz9t6X@ozlabs.org> References: <3qmfyk6wGYz9t6X@ozlabs.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 2016-04-16 at 00:27 +1000, Michael Ellerman wrote: > On Fri, 2016-15-04 at 02:06:13 UTC, Unknown sender due to SPF wrote: > > The real LE feature entry in the ibm_pa_feature struct has the > > wrong number of elements. Instead of checking for byte 5, bit 0, > > we check for byte 0, bit 0, and we also incorrectly update cpu user > > feature bit 5. > > Finally the user feature, we're setting 5, ie. 0x4 | 0x1, which is: > > #define PPC_FEATURE_PPC_LE 0x00000001 > > And nothing else, 0x4 is free. Buuuut, we should reserve 0x4 for the foreseeable future. Because it is erroneously set on older kernels. cheers